Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor subclassing of RCTEventEmitter #35106

Closed
wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

Summary:
This Diff remove the assert on the initializer in the EventEmitter in place of a more idiomatic check when the method is invoked.

It aims to solve an internal error and promotes best practices for the iOS platform.

Changelog:

[iOS][Changed] Refactor RCTEventEmitter initialization

Differential Revision: D40762253

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Oct 27, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40762253

@analysis-bot
Copy link

analysis-bot commented Oct 27, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,068,113 +0
android hermes armeabi-v7a 6,440,497 +0
android hermes x86 7,483,431 +0
android hermes x86_64 7,342,828 +0
android jsc arm64-v8a 8,933,067 +0
android jsc armeabi-v7a 7,667,418 +0
android jsc x86 8,993,443 +0
android jsc x86_64 9,472,201 +0

Base commit: dac6806
Branch: main

@analysis-bot
Copy link

analysis-bot commented Oct 27, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: dac6806
Branch: main

@pull-bot
Copy link

PR build artifact for 674b2a2 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

PR build artifact for 674b2a2 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

Summary:
Pull Request resolved: facebook#35106

This Diff remove the assert on the initializer in the EventEmitter in place of a more idiomatic check when the method is invoked.

It aims to solve an internal error and promotes best practices for the iOS platform.

## Changelog:
[iOS][Changed] Refactor RCTEventEmitter initialization

Reviewed By: sammy-SC

Differential Revision: D40762253

fbshipit-source-id: bd1473736ee4d1d7cebe7eaf3ac6c69bca83dfda
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40762253

@pull-bot
Copy link

pull-bot commented Nov 8, 2022

PR build artifact for 621cc6f is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

pull-bot commented Nov 8, 2022

PR build artifact for 621cc6f is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cipolleschi in 25a0052.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 8, 2022
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Pull Request resolved: facebook#35106

This Diff remove the assert on the initializer in the EventEmitter in place of a more idiomatic check when the method is invoked.

It aims to solve an internal error and promotes best practices for the iOS platform.

## Changelog:
[iOS][Changed] Refactor RCTEventEmitter initialization

Reviewed By: sammy-SC

Differential Revision: D40762253

fbshipit-source-id: 83d26616ce147914948e536e9e4b1010758fb690
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants