-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor subclassing of RCTEventEmitter #35106
Conversation
This pull request was exported from Phabricator. Differential Revision: D40762253 |
Base commit: dac6806 |
Base commit: dac6806 |
PR build artifact for 674b2a2 is ready. |
PR build artifact for 674b2a2 is ready. |
Summary: Pull Request resolved: facebook#35106 This Diff remove the assert on the initializer in the EventEmitter in place of a more idiomatic check when the method is invoked. It aims to solve an internal error and promotes best practices for the iOS platform. ## Changelog: [iOS][Changed] Refactor RCTEventEmitter initialization Reviewed By: sammy-SC Differential Revision: D40762253 fbshipit-source-id: bd1473736ee4d1d7cebe7eaf3ac6c69bca83dfda
674b2a2
to
621cc6f
Compare
This pull request was exported from Phabricator. Differential Revision: D40762253 |
PR build artifact for 621cc6f is ready. |
PR build artifact for 621cc6f is ready. |
This pull request was successfully merged by @cipolleschi in 25a0052. When will my fix make it into a release? | Upcoming Releases |
Summary: Pull Request resolved: facebook#35106 This Diff remove the assert on the initializer in the EventEmitter in place of a more idiomatic check when the method is invoked. It aims to solve an internal error and promotes best practices for the iOS platform. ## Changelog: [iOS][Changed] Refactor RCTEventEmitter initialization Reviewed By: sammy-SC Differential Revision: D40762253 fbshipit-source-id: 83d26616ce147914948e536e9e4b1010758fb690
Summary:
This Diff remove the assert on the initializer in the EventEmitter in place of a more idiomatic check when the method is invoked.
It aims to solve an internal error and promotes best practices for the iOS platform.
Changelog:
[iOS][Changed] Refactor RCTEventEmitter initialization
Differential Revision: D40762253