New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Map / indexed object support for TypeScript parser #35098

Closed

christophpurrer wants to merge 1 commit into facebook:main from christophpurrer:export-D40753368

Contributor

christophpurrer commented Oct 27, 2022

Summary:
Changelog:
[General][Fixed] [react-native-codegen] react-native-codegen : Add Map / indexed object support for TypeScript parser

In flow we can expose Maps via the following syntax in TM specs

+getMap: (arg: {[key: string]: ?number}) => {[key: string]: ?number};

In TypeScript writing the same spec:

readonly getMap: (arg: { [key: string]: number | null; }) => { [key: string]: number | null; };

leads to an exception the TypeScript code-gen parser

    at react-native-github/packages/react-native-codegen/src/parsers/typescript/modules/index.js:309:23```

This change fixes the TypeScript parser

Reviewed By: cipolleschi

Differential Revision: D40753368

facebook-github-bot added CLA Signed p: Facebook Partner fb-exported labels

Contributor

facebook-github-bot commented Oct 27, 2022

This pull request was exported from Phabricator. Differential Revision: D40753368

1 similar comment

Contributor

facebook-github-bot commented Oct 27, 2022

This pull request was exported from Phabricator. Differential Revision: D40753368

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request


          Add Map / indexed object support for TypeScript parser (facebook#35098)

354f637

Summary:
Pull Request resolved: facebook#35098

Changelog:
[General][Fixed] [react-native-codegen] react-native-codegen : Add Map / indexed object support for TypeScript parser

In flow we can expose Maps via the following syntax in TM specs

`
+getMap: (arg: {[key: string]: ?number}) => {[key: string]: ?number};
`

In TypeScript writing the same spec:

`
readonly getMap: (arg: { [key: string]: number | null; }) => { [key: string]: number | null; };
`

leads to an exception the TypeScript code-gen parser

```UnsupportedObjectPropertyTypeAnnotationParserError: Module NativeTurboModuleCxx: 'ObjectTypeAnnotation' cannot contain 'TSIndexSignature'.
    at react-native-github/packages/react-native-codegen/src/parsers/typescript/modules/index.js:309:23```
```
This change fixes the TypeScript parser

Differential Revision: D40753368

fbshipit-source-id: c8ad66eb9a16cb55eee2f228e0485e1315eb443e

christophpurrer force-pushed the export-D40753368 branch from 2c16914 to 354f637 Compare

October 27, 2022 14:35

Contributor

facebook-github-bot commented Oct 27, 2022

This pull request was exported from Phabricator. Differential Revision: D40753368

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request


          Add Map / indexed object support for TypeScript parser (facebook#35098)

7fe5234

Summary:
Pull Request resolved: facebook#35098

Changelog:
[General][Fixed] [react-native-codegen] react-native-codegen : Add Map / indexed object support for TypeScript parser

In flow we can expose Maps via the following syntax in TM specs

`
+getMap: (arg: {[key: string]: ?number}) => {[key: string]: ?number};
`

In TypeScript writing the same spec:

`
readonly getMap: (arg: { [key: string]: number | null; }) => { [key: string]: number | null; };
`

leads to an exception the TypeScript code-gen parser

```UnsupportedObjectPropertyTypeAnnotationParserError: Module NativeTurboModuleCxx: 'ObjectTypeAnnotation' cannot contain 'TSIndexSignature'.
    at react-native-github/packages/react-native-codegen/src/parsers/typescript/modules/index.js:309:23```
```
This change fixes the TypeScript parser

Differential Revision: D40753368

fbshipit-source-id: 3787232ad8eb85c8f1a0068e120e9d4be06a9d0f

christophpurrer force-pushed the export-D40753368 branch from 354f637 to 7fe5234 Compare

October 27, 2022 16:03

Contributor

facebook-github-bot commented Oct 28, 2022

This pull request was exported from Phabricator. Differential Revision: D40753368

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request


          Add Map / indexed object support for TypeScript parser (facebook#35098)

a6dead0

Summary:
Pull Request resolved: facebook#35098

Changelog:
[General][Fixed] [react-native-codegen] react-native-codegen : Add Map / indexed object support for TypeScript parser

In flow we can expose Maps via the following syntax in TM specs

`
+getMap: (arg: {[key: string]: ?number}) => {[key: string]: ?number};
`

In TypeScript writing the same spec:

`
readonly getMap: (arg: { [key: string]: number | null; }) => { [key: string]: number | null; };
`

leads to an exception the TypeScript code-gen parser

```UnsupportedObjectPropertyTypeAnnotationParserError: Module NativeTurboModuleCxx: 'ObjectTypeAnnotation' cannot contain 'TSIndexSignature'.
    at react-native-github/packages/react-native-codegen/src/parsers/typescript/modules/index.js:309:23```
```
This change fixes the TypeScript parser

Reviewed By: cipolleschi

Differential Revision: D40753368

fbshipit-source-id: bcddc571ab424becb96bb0c20486d6b6f438183c

christophpurrer force-pushed the export-D40753368 branch from 7fe5234 to a6dead0 Compare

October 28, 2022 06:02

Contributor

facebook-github-bot commented Oct 28, 2022

This pull request was exported from Phabricator. Differential Revision: D40753368

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request


          Add Map / indexed object support for TypeScript parser (facebook#35098)

414f1cf

Summary:
Pull Request resolved: facebook#35098

Changelog:
[General][Fixed] [react-native-codegen] react-native-codegen : Add Map / indexed object support for TypeScript parser

In flow we can expose Maps via the following syntax in TM specs

`
+getMap: (arg: {[key: string]: ?number}) => {[key: string]: ?number};
`

In TypeScript writing the same spec:

`
readonly getMap: (arg: { [key: string]: number | null; }) => { [key: string]: number | null; };
`

leads to an exception the TypeScript code-gen parser

```UnsupportedObjectPropertyTypeAnnotationParserError: Module NativeTurboModuleCxx: 'ObjectTypeAnnotation' cannot contain 'TSIndexSignature'.
    at react-native-github/packages/react-native-codegen/src/parsers/typescript/modules/index.js:309:23```
```
This change fixes the TypeScript parser

Reviewed By: cipolleschi

Differential Revision: D40753368

fbshipit-source-id: 682621a230710fb1f241d06fb75724a7c2eccad5

christophpurrer force-pushed the export-D40753368 branch from a6dead0 to 414f1cf Compare

October 28, 2022 06:55

Contributor

facebook-github-bot commented Oct 28, 2022

This pull request was exported from Phabricator. Differential Revision: D40753368

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request


          Add Map / indexed object support for TypeScript parser (facebook#35098)

5119fa1

Summary:
Pull Request resolved: facebook#35098

Changelog:
[General][Fixed] [react-native-codegen] react-native-codegen : Add Map / indexed object support for TypeScript parser

In flow we can expose Maps via the following syntax in TM specs

`
+getMap: (arg: {[key: string]: ?number}) => {[key: string]: ?number};
`

In TypeScript writing the same spec:

`
readonly getMap: (arg: { [key: string]: number | null; }) => { [key: string]: number | null; };
`

leads to an exception the TypeScript code-gen parser

```UnsupportedObjectPropertyTypeAnnotationParserError: Module NativeTurboModuleCxx: 'ObjectTypeAnnotation' cannot contain 'TSIndexSignature'.
    at react-native-github/packages/react-native-codegen/src/parsers/typescript/modules/index.js:309:23```
```
This change fixes the TypeScript parser

Reviewed By: cipolleschi

Differential Revision: D40753368

fbshipit-source-id: 71d1151d5fdcdd0ba443f82bba24f2c4e833d337

christophpurrer force-pushed the export-D40753368 branch from 414f1cf to 5119fa1 Compare

October 28, 2022 12:32

Contributor

facebook-github-bot commented Oct 28, 2022

This pull request was exported from Phabricator. Differential Revision: D40753368

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request


          Add Map / indexed object support for TypeScript parser (facebook#35098)

1f51d3a

Summary:
Pull Request resolved: facebook#35098

Changelog:
[General][Fixed] [react-native-codegen] react-native-codegen : Add Map / indexed object support for TypeScript parser

In flow we can expose Maps via the following syntax in TM specs

`
+getMap: (arg: {[key: string]: ?number}) => {[key: string]: ?number};
`

In TypeScript writing the same spec:

`
readonly getMap: (arg: { [key: string]: number | null; }) => { [key: string]: number | null; };
`

leads to an exception the TypeScript code-gen parser

```UnsupportedObjectPropertyTypeAnnotationParserError: Module NativeTurboModuleCxx: 'ObjectTypeAnnotation' cannot contain 'TSIndexSignature'.
    at react-native-github/packages/react-native-codegen/src/parsers/typescript/modules/index.js:309:23```
```
This change fixes the TypeScript parser

Reviewed By: cipolleschi

Differential Revision: D40753368

fbshipit-source-id: 22b7df8600144fa100d08c94096dc4fb16191cfb

christophpurrer force-pushed the export-D40753368 branch from 5119fa1 to 1f51d3a Compare

October 28, 2022 13:00

Contributor

facebook-github-bot commented Oct 28, 2022

This pull request was exported from Phabricator. Differential Revision: D40753368

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request


          Add Map / indexed object support for TypeScript parser (facebook#35098)

f0c2c42

Summary:
Pull Request resolved: facebook#35098

Changelog:
[General][Fixed] [react-native-codegen] react-native-codegen : Add Map / indexed object support for TypeScript parser

In flow we can expose Maps via the following syntax in TM specs

`
+getMap: (arg: {[key: string]: ?number}) => {[key: string]: ?number};
`

In TypeScript writing the same spec:

`
readonly getMap: (arg: { [key: string]: number | null; }) => { [key: string]: number | null; };
`

leads to an exception the TypeScript code-gen parser

```UnsupportedObjectPropertyTypeAnnotationParserError: Module NativeTurboModuleCxx: 'ObjectTypeAnnotation' cannot contain 'TSIndexSignature'.
    at react-native-github/packages/react-native-codegen/src/parsers/typescript/modules/index.js:309:23```
```
This change fixes the TypeScript parser

Reviewed By: cipolleschi

Differential Revision: D40753368

fbshipit-source-id: 9d0b76cebbcf8dea170b6bfce7174564a69548a6

christophpurrer force-pushed the export-D40753368 branch from 1f51d3a to f0c2c42 Compare

October 28, 2022 15:01

Contributor

facebook-github-bot commented Oct 28, 2022

This pull request was exported from Phabricator. Differential Revision: D40753368

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request


          Add Map / indexed object support for TypeScript parser (facebook#35098)

d603b04

Summary:
Pull Request resolved: facebook#35098

Changelog:
[General][Fixed] [react-native-codegen] react-native-codegen : Add Map / indexed object support for TypeScript parser

In flow we can expose Maps via the following syntax in TM specs

`
+getMap: (arg: {[key: string]: ?number}) => {[key: string]: ?number};
`

In TypeScript writing the same spec:

`
readonly getMap: (arg: { [key: string]: number | null; }) => { [key: string]: number | null; };
`

leads to an exception the TypeScript code-gen parser

```UnsupportedObjectPropertyTypeAnnotationParserError: Module NativeTurboModuleCxx: 'ObjectTypeAnnotation' cannot contain 'TSIndexSignature'.
    at react-native-github/packages/react-native-codegen/src/parsers/typescript/modules/index.js:309:23```
```
This change fixes the TypeScript parser

Reviewed By: cipolleschi

Differential Revision: D40753368

fbshipit-source-id: 66b2d55607a7520c798a2e709a1a9f1333188ebd

christophpurrer force-pushed the export-D40753368 branch from f0c2c42 to d603b04 Compare

October 28, 2022 16:41


          Add Map / indexed object support for TypeScript parser (facebook#35098)

d96f019

Summary:
Pull Request resolved: facebook#35098

Changelog:
[General][Fixed] [react-native-codegen] react-native-codegen : Add Map / indexed object support for TypeScript parser

In flow we can expose Maps via the following syntax in TM specs

`
+getMap: (arg: {[key: string]: ?number}) => {[key: string]: ?number};
`

In TypeScript writing the same spec:

`
readonly getMap: (arg: { [key: string]: number | null; }) => { [key: string]: number | null; };
`

leads to an exception the TypeScript code-gen parser

```UnsupportedObjectPropertyTypeAnnotationParserError: Module NativeTurboModuleCxx: 'ObjectTypeAnnotation' cannot contain 'TSIndexSignature'.
    at react-native-github/packages/react-native-codegen/src/parsers/typescript/modules/index.js:309:23```
```
This change fixes the TypeScript parser

Reviewed By: cipolleschi

Differential Revision: D40753368

fbshipit-source-id: cc99f91485bc6ec77a07599f8a43a909a50f85b2

Contributor

facebook-github-bot commented Oct 29, 2022

This pull request was exported from Phabricator. Differential Revision: D40753368

christophpurrer force-pushed the export-D40753368 branch from d603b04 to d96f019 Compare

October 29, 2022 21:19

facebook-github-bot closed this in

87c356d

Collaborator

react-native-bot commented Oct 30, 2022

This pull request was successfully merged by Christoph Purrer in 87c356d.

^{When will my fix make it into a release? | Upcoming Releases}

react-native-bot added the Merged label

christophpurrer mentioned this pull request

Fix codegen output for object with indexer #35344

Closed

OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request


          Add Map / indexed object support for TypeScript parser (facebook#35098)

9af54df

Summary:
Pull Request resolved: facebook#35098

Changelog:
[General][Fixed] [react-native-codegen] react-native-codegen : Add Map / indexed object support for TypeScript parser

In flow we can expose Maps via the following syntax in TM specs

`
+getMap: (arg: {[key: string]: ?number}) => {[key: string]: ?number};
`

In TypeScript writing the same spec:

`
readonly getMap: (arg: { [key: string]: number | null; }) => { [key: string]: number | null; };
`

leads to an exception the TypeScript code-gen parser

```UnsupportedObjectPropertyTypeAnnotationParserError: Module NativeTurboModuleCxx: 'ObjectTypeAnnotation' cannot contain 'TSIndexSignature'.
    at react-native-github/packages/react-native-codegen/src/parsers/typescript/modules/index.js:309:23```
```
This change fixes the TypeScript parser

Reviewed By: cipolleschi

Differential Revision: D40753368

fbshipit-source-id: 0eef8ecb63d1ed049fde1e75cc6f2ec627f1f232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner