[Codegen]: extracted UntypedModuleRegistryCallParserError to a throwing function in error-utils.js
#34953
+111
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: a885b1f |
Base commit: a885b1f |
cipolleschi
approved these changes
Oct 12, 2022
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Thank you for taking this
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
This pull request was successfully merged by @dhruvtailor7 in 1e15e21. When will my fix make it into a release? | Upcoming Releases |
mohitcharkha
pushed a commit
to mohitcharkha/react-native
that referenced
this pull request
Oct 17, 2022
…on in error-utils.js (facebook#34953) Summary: This PR is part of facebook#34872. As a part of this PR, `UntypedModuleRegistryCallParserError` is separated into its own throwing function in `error-utils.js` file and is used in both Flow and TypeScript parsers [Internal] [Changed] - Extract `UntypedModuleRegistryCallParserError` to a separate function inside `error-utils.js` file. Pull Request resolved: facebook#34953 Test Plan: Added unit case in error-utils-test.js file to test the new function. Output of `yarn jest react-native-codegen` ensures all passed test cases. <img width="450" alt="Screenshot 2022-10-12 at 12 44 36 PM" src="https://user-images.githubusercontent.com/32268377/195277708-97340db3-f3d8-48a3-9a59-95d2747c67b0.png"> Reviewed By: christophpurrer Differential Revision: D40297017 Pulled By: cipolleschi fbshipit-source-id: b02dcf0e110ab903a0d1831783194ae4a543075b
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…on in error-utils.js (facebook#34953) Summary: This PR is part of facebook#34872. As a part of this PR, `UntypedModuleRegistryCallParserError` is separated into its own throwing function in `error-utils.js` file and is used in both Flow and TypeScript parsers ## Changelog [Internal] [Changed] - Extract `UntypedModuleRegistryCallParserError` to a separate function inside `error-utils.js` file. Pull Request resolved: facebook#34953 Test Plan: Added unit case in error-utils-test.js file to test the new function. Output of `yarn jest react-native-codegen` ensures all passed test cases. <img width="450" alt="Screenshot 2022-10-12 at 12 44 36 PM" src="https://user-images.githubusercontent.com/32268377/195277708-97340db3-f3d8-48a3-9a59-95d2747c67b0.png"> Reviewed By: christophpurrer Differential Revision: D40297017 Pulled By: cipolleschi fbshipit-source-id: b02dcf0e110ab903a0d1831783194ae4a543075b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of #34872.
As a part of this PR,
UntypedModuleRegistryCallParserErroris separated into its own throwing function inerror-utils.jsfile and is used in both Flow and TypeScript parsersChangelog
[Internal] [Changed] - Extract
UntypedModuleRegistryCallParserErrorto a separate function insideerror-utils.jsfile.Test Plan
Added unit case in error-utils-test.js file to test the new function.
Output of
yarn jest react-native-codegenensures all passed test cases.