-
Notifications
You must be signed in to change notification settings - Fork 25k
[Codegen] extract emitPromise from parsers modules to shared parsers-primitives #34935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Codegen] extract emitPromise from parsers modules to shared parsers-primitives #34935
Conversation
…meter to parsers-commons
Base commit: f8996f1 |
Base commit: 2f58e52 |
|
This PR is a bit confusing, tbh... the title says one thing, but the code does at least two other things?.. :) |
6e2869c to
0ead64d
Compare
|
@AntoineDoubovetzky Ah, this makes sense, thanks for correcting the title! |
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
0ead64d to
1ce4c90
Compare
|
I rebased after adding a commit to #34933 |
|
This pull request was successfully merged by @AntoineDoubovetzky in 966f3cd. When will my fix make it into a release? | Upcoming Releases |
…facebook#34935) Summary: This PR is a task from facebook#34872: > Extract the content of the case 'Promise' ([Flow](https://github.com/facebook/react-native/blob/b444f0e44e0d8670139acea5f14c2de32c5e2ddc/packages/react-native-codegen/src/parsers/flow/modules/index.js#L90-L97), [TypeScript](https://github.com/facebook/react-native/blob/00b795642a6562fb52d6df12e367b84674994623/packages/react-native-codegen/src/parsers/typescript/modules/index.js#L197-L205)) into a single emitPromise function in the parsers-primitives.js file. Use the new function in the parsers. Note that this PR should be merged after facebook#34933 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Changed] - Extract contents of the case 'Promise' into a single emitPromise function inside parsers-primitives Pull Request resolved: facebook#34935 Test Plan: I tested using jest and flow commands. Reviewed By: cipolleschi Differential Revision: D40257033 Pulled By: cipolleschi fbshipit-source-id: 0246f43c6b688629e2de1259e7f535c2cf6dd0a4
Summary
This PR is a task from #34872:
Note that this PR should be merged after #34933
Changelog
[Internal] [Changed] - Extract contents of the case 'Promise' into a single emitPromise function inside parsers-primitives
Test Plan
I tested using jest and flow commands.