Chore/extract codegen case object to parser primitives #34926
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Marcoo09
force-pushed
the
chore/extract-case-Object-to-parser-primitives
branch
from
e561b28 to
49154d1
Compare
Marcoo09
changed the title
cipolleschi
approved these changes
Oct 10, 2022
Base commit: cb3a5cc |
Base commit: e4dff28 |
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@Marcoo09 Can you please rebase and fix the conflicts? 🙏 |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Part of facebook#34872 This PR extracts the content of the case 'Object' ([Flow](https://github.com/facebook/react-native/blob/b444f0e44e0d8670139acea5f14c2de32c5e2ddc/packages/react-native-codegen/src/parsers/flow/modules/index.js#L365-L367), [TypeScript](https://github.com/facebook/react-native/blob/00b795642a6562fb52d6df12e367b84674994623/packages/react-native-codegen/src/parsers/typescript/modules/index.js#L400-L402)) into a single emitObject function in the parsers-primitives.js file. Use the new function in the parsers. ## Changelog [Internal] [Changed] - Extract contents of the case 'Object' into a single emitObject function Pull Request resolved: facebook#34926 Test Plan: <img width="276" alt="image" src="https://user-images.githubusercontent.com/18408823/194892107-1da9d6e5-c659-47f9-8597-ff4a4b7710ca.png"> Reviewed By: rshest Differential Revision: D40231670 Pulled By: cipolleschi fbshipit-source-id: db6a61427c8c020d48be5317b094f136842b62ca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #34872
This PR extracts the content of the case 'Object' (Flow, TypeScript) into a single emitObject function in the parsers-primitives.js file. Use the new function in the parsers.
Changelog
[Internal] [Changed] - Extract contents of the case 'Object' into a single emitObject function
Test Plan