-
Notifications
You must be signed in to change notification settings - Fork 25k
Chore/extract codegen parser more than one module exception #34920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/extract codegen parser more than one module exception #34920
Conversation
|
Can you rebase on top of main? The #34896 finally landed! |
Base commit: 49cb7f2 |
7c2de98 to
b7c00b1
Compare
|
Done @cipolleschi |
|
@cipolleschi I fixed some of the flow-checks errors. Now is missing the following one: |
|
Hi @Marcoo09! export type ParserTypeand then you have to use it with the import type {ParserType} from In this way, it should work! |
packages/react-native-codegen/src/parsers/flow/modules/index.js
Outdated
Show resolved
Hide resolved
packages/react-native-codegen/src/parsers/typescript/modules/index.js
Outdated
Show resolved
Hide resolved
|
Great @cipolleschi |
|
@motiz88 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 49cb7f2 |
|
@motiz88 could you please reimport this PR? |
|
@motiz88 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
/rebase |
38869d2 to
4635134
Compare
|
@Marcoo09 could you rebase and resolve the conflicts, please? |
|
@cipolleschi sorry, just rebased |
|
Sorry to ask again, could you rebase, please? 🙏 |
4635134 to
9f60605
Compare
|
|
This pull request was successfully merged by @Marcoo09 in f628edc. When will my fix make it into a release? | Upcoming Releases |
…#34920) Summary: This PR is part of facebook#34872 This PR extracts MoreThanOneModuleInterfaceParserError exception to a separate function inside an error-utils.js file ## Changelog [Internal] [Changed] - Extract MoreThanOneModuleInterfaceParserError to a seperate function inside error-utils.js Pull Request resolved: facebook#34920 Test Plan: <img width="297" alt="image" src="https://user-images.githubusercontent.com/18408823/194859284-7d3ff330-c644-472e-9ae0-3b9444bc12e8.png"> Reviewed By: cortinico Differential Revision: D40226575 Pulled By: cipolleschi fbshipit-source-id: 01e581abfae1ffe40e92bed8c9bedd6fe09e1aab


Summary
This PR is part of #34872
This PR extracts MoreThanOneModuleInterfaceParserError exception to a separate function inside an error-utils.js file
Changelog
[Internal] [Changed] - Extract MoreThanOneModuleInterfaceParserError to a seperate function inside error-utils.js
Test Plan