Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mapbuffer module to podspec #34847

Closed
wants to merge 1 commit into from
Closed

Conversation

rshest
Copy link
Contributor

@rshest rshest commented Oct 3, 2022

Summary:
This fixes a missing intra-module dependency inside RN renderer core.

Changelog:
[iOS][Fixed] - Add missing react/renderer/mapbuffer module to podspec

Differential Revision: D40020363

Summary:
This fixes a missing intra-module dependency inside RN renderer core.

Changelog:
[iOS][Fixed] - Add missing react/renderer/mapbuffer module to podspec

Differential Revision: D40020363

fbshipit-source-id: 323115da81a669c6448fa6a1d26c730c1b91acc1
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Oct 3, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40020363

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,739,161 -131
android hermes armeabi-v7a 7,141,579 -356
android hermes x86 8,050,059 -322
android hermes x86_64 8,021,773 -424
android jsc arm64-v8a 9,607,326 -153
android jsc armeabi-v7a 8,372,583 -385
android jsc x86 9,554,794 -347
android jsc x86_64 10,147,276 -449

Base commit: 32b6f31
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: a88f805
Branch: main

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by Ruslan Shestopalyuk in 0045863.

When will my fix make it into a release? | Upcoming Releases

5 similar comments
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by Ruslan Shestopalyuk in 0045863.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by Ruslan Shestopalyuk in 0045863.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by Ruslan Shestopalyuk in 0045863.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by Ruslan Shestopalyuk in 0045863.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by Ruslan Shestopalyuk in 0045863.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 3, 2022
@rshest
Copy link
Contributor Author

rshest commented Oct 3, 2022

.

OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Pull Request resolved: facebook#34847

This fixes a missing intra-module dependency inside RN renderer core.

Changelog:
[iOS][Fixed] - Add missing react/renderer/mapbuffer module to podspec

Reviewed By: dmytrorykun

Differential Revision: D40020363

fbshipit-source-id: 5e9f3baab76536f1689f0aa5750fdb5a44d28942
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants