Skip to content

chore: Fix RNTester typos #34757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore: Fix RNTester typos #34757

wants to merge 1 commit into from

Conversation

gabrieldonadel
Copy link
Collaborator

Summary

While working on #34550 I noticed that a couple of words inside the RNTester package were misspelled, this gave me the idea to test other files as well using the VS Code extension Code Spell Checker which unveiled quite a few other typos.

Changelog

[Internal] [Fixed] - Fix RNTester typos

Test Plan

Shouldn't require much testing as this is just fixing some typos inside the RNTester package.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 21, 2022
@github-actions
Copy link

github-actions bot commented Sep 21, 2022 •
edited
Loading

Warnings
⚠️

packages/rn-tester/js/examples/Experimental/PlatformTest/RNTesterPlatformTestResultView.js#L245 - packages/rn-tester/js/examples/Experimental/PlatformTest/RNTesterPlatformTestResultView.js line 245 – Inline style: { width: '100%', height: '100%', flexDirection: 'column' } (react-native/no-inline-styles)
⚠️

packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js#L183 - packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js line 183 – Inline style: { height: 100 } (react-native/no-inline-styles)
⚠️

packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js#L327 - packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js line 327 – Inline style: { height: 400 } (react-native/no-inline-styles)
⚠️

packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js#L495 - packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js line 495 – Inline style: { height: 200 } (react-native/no-inline-styles)
⚠️

packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js#L546 - packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js line 546 – Inline style: { height: 200 } (react-native/no-inline-styles)
⚠️

packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js#L579 - packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js line 579 – Inline style: { height: 200 } (react-native/no-inline-styles)
⚠️

packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js#L639 - packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js line 639 – Inline style: { height: 200 } (react-native/no-inline-styles)
⚠️

packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js#L666 - packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js line 666 – Inline style: { height: 200 } (react-native/no-inline-styles)
⚠️

packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js#L715 - packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js line 715 – Inline style: { height: 200 } (react-native/no-inline-styles)
⚠️

packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js#L744 - packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js line 744 – Inline style: { height: 200 } (react-native/no-inline-styles)
⚠️

packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js#L763 - packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js line 763 – Inline style: { height: 200 } (react-native/no-inline-styles)
⚠️

packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js#L796 - packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js line 796 – Inline style: { height: 200 } (react-native/no-inline-styles)
⚠️

packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js#L813 - packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js line 813 – Inline style: { height: 200 } (react-native/no-inline-styles)
⚠️

packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js#L841 - packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js line 841 – Inline style: { height: 200 } (react-native/no-inline-styles)
⚠️

packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js#L895 - packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js line 895 – Inline style: { height: 200 } (react-native/no-inline-styles)
⚠️

packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js#L938 - packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js line 938 – Inline style: { height: 200 } (react-native/no-inline-styles)
⚠️

packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js#L977 - packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js line 977 – Inline style: { height: 200 } (react-native/no-inline-styles)
⚠️

packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js#L1013 - packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js line 1013 – Inline style: { height: 200 } (react-native/no-inline-styles)
⚠️

packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js#L1040 - packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js line 1040 – Inline style: { height: 200 } (react-native/no-inline-styles)
⚠️

packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js#L1083 - packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js line 1083 – Inline style: { height: 200 } (react-native/no-inline-styles)
⚠️

packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js#L1111 - packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js line 1111 – Inline style: { height: 200 } (react-native/no-inline-styles)
⚠️

packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js#L1178 - packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js line 1178 – Inline style: { height: 200 } (react-native/no-inline-styles)
⚠️

packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js#L1203 - packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js line 1203 – Inline style: { height: 200 } (react-native/no-inline-styles)
⚠️

packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js#L1225 - packages/rn-tester/js/examples/ScrollView/ScrollViewExample.js line 1225 – Inline style: { height: 200 } (react-native/no-inline-styles)

Generated by 🚫 dangerJS against dc191c9

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 21, 2022
@analysis-bot
Copy link

analysis-bot commented Sep 21, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,698,722 +49
android hermes armeabi-v7a 7,102,309 +48
android hermes x86 8,001,468 +49
android hermes x86_64 7,974,035 +47
android jsc arm64-v8a 9,569,389 -21
android jsc armeabi-v7a 8,336,396 -25
android jsc x86 9,509,812 -24
android jsc x86_64 10,101,492 -24

Base commit: 59f25da
Branch: main

@analysis-bot
Copy link

analysis-bot commented Sep 21, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 59f25da
Branch: main

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @gabrieldonadel in c2b699a.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 22, 2022
@gabrieldonadel gabrieldonadel deleted the fix/rn-tester-typos branch September 22, 2022 11:49
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@gabrieldonadel @OlimpiaZurek
chore: Fix RNTester typos (facebook#34757)
08af34a 
Summary:
While working on facebook#34550 I noticed that a couple of words inside the RNTester package were misspelled, this gave me the idea to test other files as well using the VS Code extension [Code Spell Checker](https://marketplace.visualstudio.com/items?itemName=streetsidesoftware.code-spell-checker) which unveiled quite a few other typos.

## Changelog

[Internal] [Fixed] - Fix RNTester typos

Pull Request resolved: facebook#34757

Test Plan: Shouldn't require much testing as this is just fixing some typos inside the RNTester package.

Reviewed By: dmytrorykun

Differential Revision: D39722889

Pulled By: cortinico

fbshipit-source-id: a575ab8337586c5fe2d68ce73d2aae27d24a6384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hramos hramos Awaiting requested review from hramos

Assignees
No one assigned
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabrieldonadel @analysis-bot @facebook-github-bot @react-native-bot