Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: f63d4e7 |
Collaborator
|
This pull request was successfully merged by @robhogan in a048399. When will my fix make it into a release? | Upcoming Releases |
Base commit: f63d4e7 |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: The CircleCI `test_codegen` job currently runs tests under `packages/react-native-codegen`. Because it runs from that working directory, it doesn't pick up the project root's `jest.config.js`, which is a problem for facebook#34724 (snapshot format configuration in `jest.config.js`) `react-native-codegen` tests are *already run* by the `test_js` job, as can be seen from the CircleCI logs https://app.circleci.com/pipelines/github/facebook/react-native/15818/workflows/41034d00-7061-46e8-a03d-abdcc7fd7e2f/jobs/295804/parallel-runs/0/steps/0-107 , so the job isn't necessary, and this PR removes it. CC cipolleschi ## Changelog [Internal] [Fixed] - Remove redundant `test_codegen` job from CircleCI. Pull Request resolved: facebook#34733 Test Plan: CircleCI! Reviewed By: lunaleaps Differential Revision: D39660829 Pulled By: robhogan fbshipit-source-id: d7b09cc90a30e7604e2645e2bd0c16f840443153
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CircleCI
test_codegenjob currently runs tests underpackages/react-native-codegen. Because it runs from that working directory, it doesn't pick up the project root'sjest.config.js, which is a problem for #34724 (snapshot format configuration injest.config.js)react-native-codegentests are already run by thetest_jsjob, as can be seen from the CircleCI logshttps://app.circleci.com/pipelines/github/facebook/react-native/15818/workflows/41034d00-7061-46e8-a03d-abdcc7fd7e2f/jobs/295804/parallel-runs/0/steps/0-107 , so the job isn't necessary, and this PR removes it. CC @cipolleschi
Changelog
[Internal] [Fixed] - Remove redundant
test_codegenjob from CircleCI.Test Plan
CircleCI!