Set RCT_NEW_ARCH_ENABLED to true when using cocoapod flag #34670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D39430904 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D39430904 |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 13, 2022
…4670) Summary: Pull Request resolved: facebook#34670 Users can enable the New Architecture on iOS in two way: using the `RCT_NEW_ACRH_ENABLED` env variable or setting the `new_arch_enabled` flag when invoking the `use_react_native` function. We need to set the `RCT_NEW_ACRH_ENABLED` even when the other method is used because we need to inject that flag into the codebase. ## Changelog [iOS][Fixed] Make sure to turn on the `RCT_NEW_ACRH_ENABLED` flag Differential Revision: D39430904 fbshipit-source-id: c637b965f97afdf5d7da7f53c9cc56aa9e4e2d69
cipolleschi
force-pushed
the
export-D39430904
branch
from
3471e44
to
df625cf
Compare
…4670) Summary: Pull Request resolved: facebook#34670 Users can enable the New Architecture on iOS in two way: using the `RCT_NEW_ACRH_ENABLED` env variable or setting the `new_arch_enabled` flag when invoking the `use_react_native` function. We need to set the `RCT_NEW_ACRH_ENABLED` even when the other method is used because we need to inject that flag into the codebase. ## Changelog [iOS][Fixed] Make sure to turn on the `RCT_NEW_ACRH_ENABLED` flag Differential Revision: D39430904 fbshipit-source-id: 8e8254b66846a8f93d108632a2236b42e1a91ae0
cipolleschi
force-pushed
the
export-D39430904
branch
from
df625cf
to
2f27bd6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39430904 |
ken0nek
reviewed
Sep 14, 2022
| @@ -46,6 +46,9 @@ def use_react_native! ( | |||
|
|
|||
| CodegenUtils.clean_up_build_folder(app_path, $CODEGEN_OUTPUT_DIR) | |||
|
|
|||
| # We are relying on this flag also in third parties libraries to proper install dependencies. | |||
| # Better to rely and enable this environment flag if the new architecture is turned on using flags. | |||
| ENV['RCT_NEW_ARCH_ENABLED'] = new_arch_enabled ? "1" : "0" | |||
There was a problem hiding this comment.
I'm seeing we use single quotes when there are no string interpolations.
It's okay if it doesn't work when we use single quotes here.
|
This pull request was successfully merged by @cipolleschi in f31134a. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…4670) Summary: Pull Request resolved: facebook#34670 Users can enable the New Architecture on iOS in two way: using the `RCT_NEW_ACRH_ENABLED` env variable or setting the `new_arch_enabled` flag when invoking the `use_react_native` function. We need to set the `RCT_NEW_ACRH_ENABLED` even when the other method is used because we need to inject that flag into the codebase. ## Changelog [iOS][Fixed] Make sure to turn on the `RCT_NEW_ACRH_ENABLED` flag Reviewed By: cortinico Differential Revision: D39430904 fbshipit-source-id: abb55642b4c72d7dec8b045fb4a43c1763f0ee0f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Users can enable the New Architecture on iOS in two way: using the
RCT_NEW_ACRH_ENABLEDenv variable or setting thenew_arch_enabledflag when invoking theuse_react_nativefunction.We need to set the
RCT_NEW_ACRH_ENABLEDeven when the other method is used because we need to inject that flag into the codebase.Changelog
[iOS][Fixed] Make sure to turn on the
RCT_NEW_ACRH_ENABLEDflagDifferential Revision: D39430904