-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align android image style / source logic with ios #34655
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
labels
Sep 10, 2022
danilobuerger
added a commit
to feastr/react-native
that referenced
this pull request
Sep 10, 2022
danilobuerger
force-pushed
the
androidimage
branch
from
September 10, 2022 23:51
884018a
to
9512eed
Compare
danilobuerger
added a commit
to feastr/react-native
that referenced
this pull request
Sep 10, 2022
Base commit: 4e70376 |
danilobuerger
force-pushed
the
androidimage
branch
from
September 11, 2022 00:34
9512eed
to
630656e
Compare
Base commit: 4e70376 |
danilobuerger
force-pushed
the
androidimage
branch
2 times, most recently
from
September 11, 2022 14:08
65f7532
to
ab049d8
Compare
danilobuerger
force-pushed
the
androidimage
branch
from
September 11, 2022 14:21
ab049d8
to
ae1f480
Compare
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @danilobuerger in 6bdcb49. When will my fix make it into a release? | Upcoming Releases |
danilobuerger
added a commit
to feastr/react-native
that referenced
this pull request
Nov 18, 2022
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: This aligns the logic of setting style (width / height) and source of Android with iOS. iOS handles nullish uris with set width and heigth by passing them through. Android did not. ## Changelog [Android] [Fixed] - Align android image style / source logic with ios Pull Request resolved: facebook#34655 Test Plan: ``` <Image source={{width: 100, height: 100}} /> ``` Before this Patch: * iOS: Renders a blank image with 100x100 * Android: Renders a blank image with 0x0 After this Patch: * iOS: Renders a blank image with 100x100 * Android: Renders a blank image with 100x100 Reviewed By: sammy-SC Differential Revision: D39423391 Pulled By: cipolleschi fbshipit-source-id: 997c06dea42e9b69fda12b678a1b82ad8319537f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Merged
This PR has been merged.
Platform: Android
Android applications.
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This aligns the logic of setting style (width / height) and source of Android with iOS.
iOS handles nullish uris with set width and heigth by passing them through. Android did not.
Changelog
[Android] [Fixed] - Align android image style / source logic with ios
Test Plan
Before this Patch:
After this Patch: