-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add mixed to aria-checked typings #34633
fix: add mixed to aria-checked typings #34633
Conversation
Base commit: 0d3596a |
@rubennorte has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 0d3596a |
There was an internal request to update the typescript types too. cc @lunaleaps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ankit-tailor! As Nicolas mentioned can we update the TS types here:
'aria-checked'?: ?boolean, |
and other related places if any
Yes @lunaleaps, I'll do the necessary changes. |
@lunaleaps, Only ViewAccessibility props required the above changes, other than that everywhere else ViewAccessibility props are extended. |
@lunaleaps any updates on this? |
@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @ankit-tailor in 7a19af7. When will my fix make it into a release? | Upcoming Releases |
Summary: `aria-checked` prop should accept `mixed` as value as given [here](https://www.w3.org/WAI/GL/wiki/Using_WAI-ARIA_aria-checked%3Dmixed) and also [accessibilityState.checked](https://reactnative.dev/docs/accessibility#accessibilitystate) accepts mixed to represent checkboxes. This change refers to issue facebook#34424 and PR facebook#34524 ## Changelog [General] [Added] - Added `mixed` value for `aria-checked`. Pull Request resolved: facebook#34633 Test Plan: ```js <TouchableOpacity accessibilityRole="checkbox" aria-checked="mixed" accessibilityHint="click me to change state"> <Text>Checkbox example</Text> </TouchableOpacity> ``` Reviewed By: lunaleaps Differential Revision: D39382158 Pulled By: necolas fbshipit-source-id: fa026274111305cc0bcbb42ed974ca1be7d779a5
Summary
aria-checked
prop should acceptmixed
as value as given here and also accessibilityState.checked accepts mixed to represent checkboxes. This change refers to issue #34424 and PR #34524Changelog
[General] [Added] - Added
mixed
value foraria-checked
.Test Plan