feat: Add string support for aspectRatio

Libraries/Components/View/ReactNativeStyleAttributes.js

@@ -9,6 +9,7 @@
  */
 
 import type {AnyAttributeType} from '../../Renderer/shims/ReactNativeTypes';
+import processAspectRatio from '../../StyleSheet/processAspectRatio';
 import processColor from '../../StyleSheet/processColor';
 import processFontVariant from '../../StyleSheet/processFontVariant';
 import processTransform from '../../StyleSheet/processTransform';
@@ -23,7 +24,7 @@ const ReactNativeStyleAttributes: {[string]: AnyAttributeType, ...} = {
   alignContent: true,
   alignItems: true,
   alignSelf: true,
-  aspectRatio: true,
+  aspectRatio: {process: processAspectRatio},
   borderBottomWidth: true,
   borderEndWidth: true,
   borderLeftWidth: true,

Libraries/StyleSheet/StyleSheetTypes.d.ts

@@ -33,7 +33,7 @@ export interface FlexStyle {
     | undefined;
   alignItems?: FlexAlignType | undefined;
   alignSelf?: 'auto' | FlexAlignType | undefined;
-  aspectRatio?: number | undefined;
+  aspectRatio?: number | string | undefined;
   borderBottomWidth?: number | undefined;
   borderEndWidth?: number | string | undefined;
   borderLeftWidth?: number | undefined;

Libraries/StyleSheet/StyleSheetTypes.js

@@ -446,8 +446,7 @@ type ____LayoutStyle_Internal = $ReadOnly<{
   flexBasis?: number | string,
 
   /**
-   * Aspect ratio control the size of the undefined dimension of a node. Aspect ratio is a
-   * non-standard property only available in react native and not CSS.
+   * Aspect ratio control the size of the undefined dimension of a node.
    *
    * - On a node with a set width/height aspect ratio control the size of the unset dimension
    * - On a node with a set flex basis aspect ratio controls the size of the node in the cross axis
@@ -457,8 +456,13 @@ type ____LayoutStyle_Internal = $ReadOnly<{
    * - On a node with flex grow/shrink aspect ratio controls the size of the node in the cross axis
    *   if unset
    * - Aspect ratio takes min/max dimensions into account
+   *
+   * Supports a number or a ratio, e.g.:
+   * - aspectRatio: '1 / 1'
+   * - aspectRatio: '1'
+   * - aspectRatio: '1'
    */
-  aspectRatio?: number,
+  aspectRatio?: number | string,
 
   /** `zIndex` controls which components display on top of others.
    *  Normally, you don't use `zIndex`. Components render according to

Libraries/StyleSheet/__tests__/__snapshots__/processAspectRatio-test.js.snap

@@ -0,0 +1,7 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`processAspectRatio should not accept invalid formats 1`] = `"aspectRatio must either be a number, a ratio or \`auto\`. You passed: 0a"`;
+
+exports[`processAspectRatio should not accept invalid formats 2`] = `"aspectRatio must either be a number, a ratio or \`auto\`. You passed: 1 / 1 1"`;
+
+exports[`processAspectRatio should not accept invalid formats 3`] = `"aspectRatio must either be a number, a ratio or \`auto\`. You passed: auto 1/1"`;

Libraries/StyleSheet/__tests__/processAspectRatio-test.js

@@ -0,0 +1,50 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @format
+ * @emails oncall+react_native
+ */
+
+'use strict';
+
+const processAspectRatio = require('../processAspectRatio');
+
+describe('processAspectRatio', () => {
+  it('should accept numbers', () => {
+    expect(processAspectRatio(1)).toBe(1);
+    expect(processAspectRatio(0)).toBe(0);
+    expect(processAspectRatio(1.5)).toBe(1.5);
+  });
+
+  it('should accept string numbers', () => {
+    expect(processAspectRatio('1')).toBe(1);
+    expect(processAspectRatio('0')).toBe(0);
+    expect(processAspectRatio('1.5')).toBe(1.5);
+    expect(processAspectRatio('+1.5')).toBe(1.5);
+    expect(processAspectRatio('   1')).toBe(1);
+    expect(processAspectRatio('   0    ')).toBe(0);
+  });
+
+  it('should accept `auto`', () => {
+    expect(processAspectRatio('auto')).toBe(undefined);
+    expect(processAspectRatio(' auto')).toBe(undefined);
+    expect(processAspectRatio(' auto  ')).toBe(undefined);
+  });
+
+  it('should accept ratios', () => {
+    expect(processAspectRatio('+1/1')).toBe(1);
+    expect(processAspectRatio('0 / 10')).toBe(0);
+    expect(processAspectRatio('117/ 13')).toBe(9);
+    expect(processAspectRatio('1.5 /1.2')).toBe(1.25);
+    expect(processAspectRatio('1/0')).toBe(Infinity);
+  });
+
+  it('should not accept invalid formats', () => {
+    expect(() => processAspectRatio('0a')).toThrowErrorMatchingSnapshot();
+    expect(() => processAspectRatio('1 / 1 1')).toThrowErrorMatchingSnapshot();
+    expect(() => processAspectRatio('auto 1/1')).toThrowErrorMatchingSnapshot();
+  });
+});

Libraries/StyleSheet/processAspectRatio.js

@@ -0,0 +1,53 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @format
+ * @flow
+ */
+
+'use strict';
+
+const invariant = require('invariant');
+
+function processAspectRatio(aspectRatio: number | string): ?number {
+  if (typeof aspectRatio === 'number') {
+    return aspectRatio;
+  }
+
+  const matches = aspectRatio.split('/').map(s => s.trim());
+
+  if (matches.includes('auto')) {
+    if (__DEV__) {
+      invariant(
+        matches.length,
+        'aspectRatio does not support `auto <ratio>`. You passed: %s',
+        aspectRatio,
+      );
+    }
+    return;
+  }
+
+  const hasNonNumericValues = matches.some(n => Number.isNaN(Number(n)));
+  if (__DEV__) {
+    invariant(
+      !hasNonNumericValues && (matches.length === 1 || matches.length === 2),
+      'aspectRatio must either be a number, a ratio or `auto`. You passed: %s',
+      aspectRatio,
+    );
+  }
+
+  if (hasNonNumericValues) {
+    return;
+  }
+
+  if (matches.length === 2) {
+    return Number(matches[0]) / Number(matches[1]);
+  }
+
+  return Number(matches[0]);
+}
+
+module.exports = processAspectRatio;