-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support TypeScript type (T)
for turbo module codegen (module only)
#34621
Conversation
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@ZihanChen-MSFT, for this case at least, could you add a new case to the snapshot tests? |
Base commit: e8739e9 |
4f7a8b3
to
929ed19
Compare
@RSNara Done! |
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: e8739e9 |
This pull request was successfully merged by @ZihanChen-MSFT in 624bdc7. When will my fix make it into a release? | Upcoming Releases |
…acebook#34621) Summary: 1. In some situation (I don't know exactly how it is triggered but I found that during porting it to `react-native-windows`), `ExportNamedDeclaration.exportKind` is missing. Just skip the checking to `exportKind` because the rest of the checking is sufficient without reading this field. 2. Add `TSParenthesizedType` to module codegen in TypeScript, so that type `(T)` is treated like `T`. ## Changelog [General] [Changed] - codegen: support TypeScript type `(T)` for turbo module codegen (module only) Pull Request resolved: facebook#34621 Test Plan: `yarn jest` passed in `packages/react-native-codegen` Reviewed By: RSNara Differential Revision: D39322001 Pulled By: cipolleschi fbshipit-source-id: 1855711da7062a065c05a10f275e26baa88cf75f
Summary
react-native-windows
),ExportNamedDeclaration.exportKind
is missing. Just skip the checking toexportKind
because the rest of the checking is sufficient without reading this field.TSParenthesizedType
to module codegen in TypeScript, so that type(T)
is treated likeT
.Changelog
[General] [Changed] - codegen: support TypeScript type
(T)
for turbo module codegen (module only)Test Plan
yarn jest
passed inpackages/react-native-codegen