Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/fontweight number value #34598

Closed
wants to merge 6 commits into from
Closed

Feat/fontweight number value #34598

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
57e2d5b
feat: number fontweight to string
ankit-tailor Sep 5, 2022
912154b
feat: fontweight number typings
ankit-tailor Sep 5, 2022
db974e0
fix: change fontweight value
ankit-tailor Sep 6, 2022
a3d332d
feat: add example for number value
ankit-tailor Sep 6, 2022
76e25c8
feat: example for all number values
ankit-tailor Sep 6, 2022
93acdbf
Remove null check its already in if condition
ankit-tailor Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove null check its already in if condition 
Co-authored-by: Fedir Ushakov <pmahotsava@gmail.com>
  • Loading branch information
@ankit-tailor @todorone
ankit-tailor and todorone authored Sep 7, 2022
commit 93acdbf1f98e062e3855e2dda109c888c18a041d
2 changes: 1 addition & 1 deletion Libraries/Text/Text.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ const Text: React.AbstractComponent<
let flattenedStyle = flattenStyle(style);

if (typeof flattenedStyle?.fontWeight === 'number') {
flattenedStyle.fontWeight = flattenedStyle?.fontWeight.toString();
flattenedStyle.fontWeight = flattenedStyle.fontWeight.toString();
}

return hasTextAncestor ? (
Expand Down