[RN][OSS] Make react-native-codegen tests run in OSS #34594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
changed the title
Base commit: a50e6fb |
cipolleschi
force-pushed
the
fix/codegen-tests
branch
from
092fe5b to
5e12496
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: a50e6fb |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @cipolleschi in 00458c9. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: During the CoreContributor summit, we discovered that the `react-native-codegen` tests cannot be executed in the OSS due to this [issue with Jest](jestjs/jest#2567). This PR moves the required variables inside the proper closure so that we can run tests in the OSS. ## Changelog [General] [Fixed] - Enable the `react-native-codegen` tests in the OSS. Pull Request resolved: facebook#34594 Test Plan: 1. Run `yarn install` in the `react-native-codegen` folder. 2. Run `yarn jest`, see the test fail. 3. Apply the changes in this diff. 4. Run `yarn jest`, see the test pass. Reviewed By: cortinico Differential Revision: D39259164 Pulled By: cipolleschi fbshipit-source-id: 7c4c0a7baa3c9b5e90a7ef75a37a0ec9d1b89db0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
During the CoreContributor summit, we discovered that the
react-native-codegentests cannot be executed in the OSS due to this issue with Jest.This PR moves the required variables inside the proper closure so that we can run tests in the OSS.
Changelog
[General] [Fixed] - Enable the
react-native-codegentests in the OSS.Test Plan
yarn installin thereact-native-codegenfolder.yarn jest, see the test fail.yarn jest, see the test pass.