Rename `assets` to `assets-registry` #34572

fortmarek · 2022-09-02T09:09:13Z

Summary

Changelog

[General] [Changed] - Rename assets to assets-registry

Test Plan

github-actions · 2022-09-02T09:10:28Z

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 23d1e08

facebook-github-bot · 2022-09-02T09:32:49Z

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

analysis-bot · 2022-09-02T09:35:14Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,103,533	+0
android	hermes	armeabi-v7a	6,471,857	+0
android	hermes	x86	7,521,168	+0
android	hermes	x86_64	7,380,054	+0
android	jsc	arm64-v8a	8,968,359	+0
android	jsc	armeabi-v7a	7,699,467	+0
android	jsc	x86	9,030,658	+0
android	jsc	x86_64	9,508,690	+0

Base commit: 8b8f4f3
Branch: main

facebook-github-bot · 2022-09-02T09:39:41Z

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

analysis-bot · 2022-09-02T11:03:28Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 8b8f4f3
Branch: main

cortinico · 2022-09-15T13:36:13Z

packages/assets-registry/BUCK

@@ -2,7 +2,7 @@ load("@fbsource//tools/build_defs/third_party:yarn_defs.bzl", "yarn_workspace")
 load("@fbsource//xplat/js:JS_DEFS.bzl", "rn_library")

 rn_library(
-    name = "assets",


Commenting here but valid for the whole PR:

Let's undo the BUCK update and the path change. It will make easier for us to import and merge this change 👍

I've also posted an update on the monorepo effort there:

☂️ React Native Monorepo #34692

Summary: This PR adds [verdaccio](https://github.com/verdaccio/verdaccio) to release packages in the `packages` directory during the E2E test on CI. The rationale behind this is the following: - Firstly, we wanted to push the [monorepo RFC](react-native-community/discussions-and-proposals#480). We hit an issue when renaming the packages to follow the same convention caused by the e2e test using the template to fail. This is because the template installs packages from the live version of npm – and if you just rename a package in a given PR without releasing it, the package understandably can't be installed since it's not published, yet – as you can see [here](https://app.circleci.com/pipelines/github/facebook/react-native/15286/workflows/149df51f-f59b-4eb3-b92c-20c513111f04/jobs/282135?invite=true#step-108-283). - Secondly, the current e2e test on `main` does not actually test the latest code of the packages in the `packages` directory as it simply downloads the latest versions from npm. This creates a divide between what's tested and what users should expect when using nightlies or when a new minor is released. ## Changelog  [Internal] [Changed] - Use verdaccio for template e2e test Pull Request resolved: #34577 Test Plan: `test_js` CI check should pass. Additionally, I have temporarily updated the [PR](#34572) renaming `assets` to `assets-registry` to include the verdaccio changes – the `test_js` passes there, additionally proving merging this PR will unblock us with the rename PRs. Reviewed By: cipolleschi Differential Revision: D39723048 Pulled By: cortinico fbshipit-source-id: aeff3811967360740df3b3dbf1df50e506fb72d8

fortmarek · 2022-09-28T12:34:11Z

I've updated the PR, so it includes only the version bump and package renaming 🤞

cortinico · 2022-10-03T14:04:25Z

@fortmarek can you rebase and fix the merge conflicts?

pull-bot · 2022-11-18T10:37:42Z

PR build artifact for e4533d6 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-18T10:38:11Z

PR build artifact for e4533d6 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

cortinico · 2022-11-23T17:49:02Z

Thanks for the rebase @fortmarek
@hoxyq is looking into merging those PRs by adapting our internal infra to let them work fine 👍

pull-bot · 2022-11-25T10:45:25Z

PR build artifact for eceb227 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-25T10:47:04Z

PR build artifact for eceb227 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

facebook-github-bot · 2022-11-25T11:04:19Z

@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

pull-bot · 2022-11-25T22:16:15Z

PR build artifact for 23d1e08 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-25T22:21:47Z

PR build artifact for 23d1e08 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

react-native-bot · 2022-11-30T20:30:08Z

This pull request was successfully merged by @fortmarek in 3c5a829.

^{When will my fix make it into a release? | Upcoming Releases}

Summary: This PR adds [verdaccio](https://github.com/verdaccio/verdaccio) to release packages in the `packages` directory during the E2E test on CI. The rationale behind this is the following: - Firstly, we wanted to push the [monorepo RFC](react-native-community/discussions-and-proposals#480). We hit an issue when renaming the packages to follow the same convention caused by the e2e test using the template to fail. This is because the template installs packages from the live version of npm – and if you just rename a package in a given PR without releasing it, the package understandably can't be installed since it's not published, yet – as you can see [here](https://app.circleci.com/pipelines/github/facebook/react-native/15286/workflows/149df51f-f59b-4eb3-b92c-20c513111f04/jobs/282135?invite=true#step-108-283). - Secondly, the current e2e test on `main` does not actually test the latest code of the packages in the `packages` directory as it simply downloads the latest versions from npm. This creates a divide between what's tested and what users should expect when using nightlies or when a new minor is released. ## Changelog  [Internal] [Changed] - Use verdaccio for template e2e test Pull Request resolved: facebook#34577 Test Plan: `test_js` CI check should pass. Additionally, I have temporarily updated the [PR](facebook#34572) renaming `assets` to `assets-registry` to include the verdaccio changes – the `test_js` passes there, additionally proving merging this PR will unblock us with the rename PRs. Reviewed By: cipolleschi Differential Revision: D39723048 Pulled By: cortinico fbshipit-source-id: aeff3811967360740df3b3dbf1df50e506fb72d8

Summary: Part of the [monorepo RFC](https://github.com/react-native-community/discussions-and-proposals/blob/04671deebe4ef2af782e281bbd912a8597c5af96/proposals/0006-react-native-monorepo.md) ## Changelog  [General] [Changed] - Rename assets to assets-registry Pull Request resolved: facebook#34572 Reviewed By: cortinico Differential Revision: D39235817 Pulled By: hoxyq fbshipit-source-id: ff4d4a7ff980d3fc6e28b83ad3b36250eba79fc3

fortmarek requested a review from hramos as a code owner September 2, 2022 09:09

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Shopify Partner: Shopify Partner labels Sep 2, 2022

facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 2, 2022

fortmarek force-pushed the rename/packager-assets branch from e14bb07 to 55063f3 Compare September 2, 2022 09:38

fortmarek force-pushed the rename/packager-assets branch 2 times, most recently from 0d20b68 to d351910 Compare September 12, 2022 09:21

kelset added the Tech: Monorepo For PRs that are related to the monorepo infra label Sep 12, 2022

fortmarek mentioned this pull request Sep 12, 2022

Use verdaccio for the template e2e test #34577

Closed

cortinico mentioned this pull request Sep 14, 2022

☂️ React Native Monorepo #34692

Closed

11 tasks

cortinico reviewed Sep 15, 2022

View reviewed changes

fortmarek force-pushed the rename/packager-assets branch from d351910 to dcbe802 Compare September 28, 2022 12:32

fortmarek requested a review from cortinico September 28, 2022 12:33

janicduplessis mentioned this pull request Oct 5, 2022

Use asset catalog for ios images #30129

Open

fortmarek force-pushed the rename/packager-assets branch from dcbe802 to e4533d6 Compare November 18, 2022 09:29

hoxyq force-pushed the rename/packager-assets branch from e4533d6 to eceb227 Compare November 25, 2022 09:39

fortmarek added 2 commits November 25, 2022 21:46

Rename @react-native/assets to @react-native/assets-registry

4e0a41e

Bump assets version

23d1e08

hoxyq force-pushed the rename/packager-assets branch from eceb227 to 23d1e08 Compare November 25, 2022 21:47

facebook-github-bot closed this in 3c5a829 Nov 30, 2022

react-native-bot added the Merged This PR has been merged. label Nov 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename `assets` to `assets-registry` #34572

Rename `assets` to `assets-registry` #34572

fortmarek commented Sep 2, 2022

github-actions bot commented Sep 2, 2022 •

edited

Loading

facebook-github-bot commented Sep 2, 2022

analysis-bot commented Sep 2, 2022 •

edited

Loading

facebook-github-bot commented Sep 2, 2022

analysis-bot commented Sep 2, 2022 •

edited

Loading

cortinico Sep 15, 2022

fortmarek commented Sep 28, 2022

cortinico commented Oct 3, 2022

pull-bot commented Nov 18, 2022

pull-bot commented Nov 18, 2022

cortinico commented Nov 23, 2022

pull-bot commented Nov 25, 2022

pull-bot commented Nov 25, 2022

facebook-github-bot commented Nov 25, 2022

pull-bot commented Nov 25, 2022

pull-bot commented Nov 25, 2022

react-native-bot commented Nov 30, 2022

Rename assets to assets-registry #34572

Rename assets to assets-registry #34572

Conversation

fortmarek commented Sep 2, 2022

Summary

Changelog

Test Plan

github-actions bot commented Sep 2, 2022 • edited Loading

facebook-github-bot commented Sep 2, 2022

analysis-bot commented Sep 2, 2022 • edited Loading

facebook-github-bot commented Sep 2, 2022

analysis-bot commented Sep 2, 2022 • edited Loading

cortinico Sep 15, 2022

Choose a reason for hiding this comment

fortmarek commented Sep 28, 2022

cortinico commented Oct 3, 2022

pull-bot commented Nov 18, 2022

pull-bot commented Nov 18, 2022

cortinico commented Nov 23, 2022

pull-bot commented Nov 25, 2022

pull-bot commented Nov 25, 2022

facebook-github-bot commented Nov 25, 2022

pull-bot commented Nov 25, 2022

pull-bot commented Nov 25, 2022

react-native-bot commented Nov 30, 2022

Rename `assets` to `assets-registry` #34572

Rename `assets` to `assets-registry` #34572

github-actions bot commented Sep 2, 2022 •

edited

Loading

analysis-bot commented Sep 2, 2022 •

edited

Loading

analysis-bot commented Sep 2, 2022 •

edited

Loading