Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add post notification Android permission #34564

Closed
wants to merge 1 commit into from
Closed

feat: add post notification Android permission #34564

wants to merge 1 commit into from

Conversation

rickafds
Copy link

@rickafds rickafds commented Sep 1, 2022

Summary

This PR add the permission POST_NOTIFICATIONS in Android, recently released Android 13

https://developer.android.com/reference/android/Manifest.permission#POST_NOTIFICATIONS

Changelog

[Android] [Changed] - Add POST_NOTIFICATIONS to PermissionsAndroid

Test Plan

PermissionsAndroid.PERMISSIONS.POST_NOTIFICATIONS === 'android.permission.POST_NOTIFICATIONS'

@facebook-github-bot
Copy link
Contributor

Hi @rickafds!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@react-native-bot react-native-bot added the Platform: Android Android applications. label Sep 1, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 1, 2022
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,636,571 -21
android hermes armeabi-v7a 7,048,561 -30
android hermes x86 7,938,539 -16
android hermes x86_64 7,910,553 -27
android jsc arm64-v8a 9,512,841 -44
android jsc armeabi-v7a 8,288,134 -51
android jsc x86 9,452,388 -35
android jsc x86_64 10,043,639 -31

Base commit: c89f5fd
Branch: main

@rickafds rickafds closed this Sep 1, 2022
@rickafds rickafds deleted the feat/permission-notification branch September 1, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Platform: Android Android applications. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants