Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added aria-modal as alias for accessibilityViewIsModal(iOS) #34506

Closed
wants to merge 11 commits into from
Closed

feat: added aria-modal as alias for accessibilityViewIsModal(iOS) #34506

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
91a4124
feat: added ariaModal as alias for accessibilityViewIsModal
Aug 26, 2022
04cf3c9
improved the documentation
Aug 26, 2022
d708cfe
Merge branch 'main' into feat/add-aria-modal-alias-for-accessibility-…
Aug 26, 2022
75e405c
added a check for aria-model
Aug 26, 2022
ce50c93
Merge branch 'facebook:main' into feat/add-aria-modal-alias-for-acces…
Sep 1, 2022
1255ab8
Merge branch 'facebook:main' into feat/add-aria-modal-alias-for-acces…
Sep 6, 2022
1e52fe6
Merge branch 'main' into feat/add-aria-modal-alias-for-accessibility-…
Sep 8, 2022
97fbf1c
Merge branch 'main' into feat/add-aria-modal-alias-for-accessibility-…
Sep 8, 2022
6f5e29b
Merge branch 'facebook:main' into feat/add-aria-modal-alias-for-acces…
Sep 8, 2022
13b5e10
Merge branch 'main' into feat/add-aria-modal-alias-for-accessibility-…
Sep 9, 2022
ad116e0
review changes
Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improved the documentation
  • Loading branch information
Daksh Bhardwaj committed Aug 26, 2022
commit 04cf3c954dff138ab1e7fd9f149bd6686b88db7f
4 changes: 3 additions & 1 deletion Libraries/Components/View/ViewPropTypes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,9 @@ type IOSViewProps = $ReadOnly<{|
accessibilityViewIsModal?: ?boolean,

/**
* The aria-modal attribute indicates whether an element is modal when displayed.
* The aria-modal attribute indicates content contained within a modal with aria-modal="true"
* should be accessible to the user.
* Default is `false`.
*
* @platform ios
*/
Expand Down