Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the cache keys to fix Hermes #34491

Closed
wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Aug 24, 2022

Summary

This PR bumps the Hermes cache keys because they got corrupted due to some sync delay between Hermes and React Native.

Changelog

[iOS] [Fixed] - CI broken due to Hermes Commit

Test Plan

CI should be green

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Aug 24, 2022
@cipolleschi cipolleschi marked this pull request as ready for review August 24, 2022 09:31
@cipolleschi cipolleschi marked this pull request as draft August 24, 2022 09:31
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: de75a7a
Branch: main

@cipolleschi cipolleschi changed the title fix: Try to update the cache keys to fix hermes Update the cache keys to fix Hermes Aug 24, 2022
@cipolleschi cipolleschi marked this pull request as ready for review August 24, 2022 11:29
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cipolleschi in ff7f5a3.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Aug 24, 2022
@yungsters yungsters deleted the fix/test_ios_after_hermes_commit branch September 29, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner Platform: iOS iOS applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants