Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding pager, scrollview, viewgroup, webview, drawer roles #34477

Closed
wants to merge 35 commits into from
Closed

Adding pager, scrollview, viewgroup, webview, drawer roles #34477

wants to merge 35 commits into from

Commits on Aug 18, 2022

  1. adding roles and traits to java/js files

    @fabOnReact
    fabOnReact committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    343279e View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2022

  1. update class names

    @fabOnReact
    fabOnReact committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    b0c8d91 View commit details
    Browse the repository at this point in the history

  2. adding scrollview and horizontal scrollview

    @fabOnReact
    fabOnReact committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    82b309a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into roles-and-traits

    @fabOnReact
    fabOnReact committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    1d246f1 View commit details
    Browse the repository at this point in the history

  4. adding new roles examples

    @fabOnReact
    fabOnReact committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    a48d4f0 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into roles-and-traits

    @fabOnReact
    fabOnReact committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    c8084c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2022

  1. Merge branch 'main' into roles-and-traits

    @fabOnReact
    fabOnReact committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    c9e5d7a View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. Add custom roles not available in compositor.json (facebook#30839, co… 

    …mmit 2a19cb8)

Add roles to strings_unlocalized.xml
Call setRoleDescription for all roles not available in compositor.json

https://github.com/google/talkback/blob/771de7cdbf55b6adb4ca4c64c27a52584f2337cc/compositor/src/main/res/raw/compositor.json#L1082-L1108
facebook#30839
facebook@da899c0
https://github.com/google/talkback/blob/771de7cdbf55b6adb4ca4c64c27a52584f2337cc/compositor/src/main/res/values/strings.xml#L223
    @fabOnReact
    fabOnReact committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    a38d81c View commit details
    Browse the repository at this point in the history

  2. adding missing roles to AccessibilityRole type

    @fabOnReact
    fabOnReact committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    569cd1c View commit details
    Browse the repository at this point in the history

  3. minor changes to Example

    @fabOnReact
    fabOnReact committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    d2bddb2 View commit details
    Browse the repository at this point in the history

  4. Fix Talkback annoucements with Drawer 

    sliding drawer
https://user-images.githubusercontent.com/24992535/186176021-ca3d8380-1ff9-449f-a738-f954edfe6328.mp4

drawerlayout (left)
https://user-images.githubusercontent.com/24992535/186176241-d84b2458-6928-4a33-957e-86ec8b427835.mp4

drawerlayout (right)
https://user-images.githubusercontent.com/24992535/186176280-4389b45c-1b0f-4d62-b6f8-29210f154558.mp4

iconmenu
https://user-images.githubusercontent.com/24992535/186176715-57c6a752-dff2-4088-820c-886d10b70378.mp4
    @fabOnReact
    fabOnReact committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    d267860 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. using setTag instead of instance variable for accessibilityRole

    @fabOnReact
    fabOnReact committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    578e29c View commit details
    Browse the repository at this point in the history

  2. ScrollView AccessibilityRole 

    1) Remove toast AccessibilityRole facebook#34477 (comment)
2) Adding ScrollView AccessibilityRole
    @fabOnReact
    fabOnReact committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    83960b7 View commit details
    Browse the repository at this point in the history

  3. datepicker and timepicker are deprecated 

    facebook#30839 (comment)
    @fabOnReact
    fabOnReact committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    d7bcd28 View commit details
    Browse the repository at this point in the history

  4. running google-java-format

    @fabOnReact
    fabOnReact committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    805cee4 View commit details
    Browse the repository at this point in the history

  5. removing not relevant roles

    @fabOnReact
    fabOnReact committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    a4ae90c View commit details
    Browse the repository at this point in the history

  6. minor changes

    @fabOnReact
    fabOnReact committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    2d73468 View commit details
    Browse the repository at this point in the history

  7. fix circle ci errors 

    https://app.circleci.com/pipelines/github/facebook/react-native/15044/workflows/08a4ef3f-2379-4f22-adf1-b5ff6bcfdab3/jobs/277959
https://app.circleci.com/pipelines/github/facebook/react-native/15044/workflows/476b5c2d-c9f8-425c-b419-edd1bd293367/jobs/277958
    @fabOnReact
    fabOnReact committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    42667ff View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Merge branch 'main' into roles-and-traits

    @fabOnReact
    fabOnReact committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    58c2fc4 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Merge branch 'main' into roles-and-traits

    @fabOnReact
    fabOnReact committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    bd5f11e View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. Add UIAccessibilityTraitNone (link) to missing roles on iOS (facebook… 

    …#34477)

https://github.com/facebook/react-native/blob/bd5f11e93bae3b420a1cd993eda09f1cd9bdc585/React/Views/RCTViewManager.m#L29
https://developer.apple.com/documentation/uikit/uiaccessibilitytraitnone?language=objc
    @fabOnReact
    fabOnReact committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    1b69235 View commit details
    Browse the repository at this point in the history

  2. seekcontrol already exist on Android/iOS as adjustable

    @fabOnReact
    fabOnReact committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    d460d09 View commit details
    Browse the repository at this point in the history

  3. remove checkedtextview 

    facebook#34477 (comment)
    @fabOnReact
    fabOnReact committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    45235d3 View commit details
    Browse the repository at this point in the history

  4. remove duplicate role checkbox

    @fabOnReact
    fabOnReact committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    f694992 View commit details
    Browse the repository at this point in the history

  5. adding AppCompatEditText for edittext and fix runtime 

    https://user-images.githubusercontent.com/24992535/187651368-ac1d6455-e817-43f8-8387-f516738a4c3f.mp4
    @fabOnReact
    fabOnReact committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    0f07b2e View commit details
    Browse the repository at this point in the history

  6. TextInput does not need an EditText role on Android. Adding the EditT… 

    …ext role removes TalkBack announcements.

The relevant logic is in https://github.com/aosp-mirror/platform_frameworks_base/blob/e648d3cb91f9a0156c729ca18ec27e71f59f9ce2/core/java/android/widget/TextView.java#L12291
https://user-images.githubusercontent.com/24992535/187655686-f6bac081-dd6b-4534-bd02-a11a5bcf27c8.mp4
    @fabOnReact
    fabOnReact committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    fc60bd6 View commit details
    Browse the repository at this point in the history

  7. minor changes

    @fabOnReact
    fabOnReact committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    1955558 View commit details
    Browse the repository at this point in the history

  8. minor changes

    @fabOnReact
    fabOnReact committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    2504fbd View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. Merge branch 'main' into roles-and-traits

    @fabOnReact
    fabOnReact committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    a87b298 View commit details
    Browse the repository at this point in the history

  2. code review from Brett 

    https://github.com/facebook/react-native/pull/34477/files#r959904998
https://github.com/facebook/react-native/pull/34477/files#r959890473
    @fabOnReact
    fabOnReact committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    d5690b6 View commit details
    Browse the repository at this point in the history

  3. adding drawerlayout example

    @fabOnReact
    fabOnReact committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    9764c48 View commit details
    Browse the repository at this point in the history

  4. drawer layout

    @fabOnReact
    fabOnReact committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    ab893d9 View commit details
    Browse the repository at this point in the history

  5. fix circleci errors flowandroid

    @fabOnReact
    fabOnReact committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    9801320 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2022

  1. Merge branch 'main' into roles-and-traits

    @fabOnReact
    fabOnReact committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    9f89049 View commit details
    Browse the repository at this point in the history

  2. update example

    @fabOnReact
    fabOnReact committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    e1c2878 View commit details
    Browse the repository at this point in the history