-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Macro Errors for Windows #34299
Fix Macro Errors for Windows #34299
Conversation
Base commit: 1a9fb6c |
Base commit: 1a9fb6c |
@JoshuaGross can you review this? Also any idea about the failing CI job? |
Note more changes might be needed here because we are still working through bugs on our end produced by the 7/4 build |
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Ok PR is ready for review! |
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @chiaramooney in fc26dbf. When will my fix make it into a release? | Upcoming Releases |
Summary: Fix macro errors for Windows. Current syntax breaks the build of the React Common project on Windows because the ({...}) syntax is not supported; must be replaced with lambda expressions. Resolves facebook#34090 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [General] [Fixed] - Fix macro errors for Windows. lyahdav JoshuaGross Pull Request resolved: facebook#34299 Test Plan: Build on react-native-windows repo. Tested in RNW app. Reviewed By: javache Differential Revision: D38272966 Pulled By: NickGerleman fbshipit-source-id: e76eac11cde173ef49465d01d793c593017f2ab7
Summary: Fix macro errors for Windows. Current syntax breaks the build of the React Common project on Windows because the ({...}) syntax is not supported; must be replaced with lambda expressions. Resolves facebook#34090 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [General] [Fixed] - Fix macro errors for Windows. lyahdav JoshuaGross Pull Request resolved: facebook#34299 Test Plan: Build on react-native-windows repo. Tested in RNW app. Reviewed By: javache Differential Revision: D38272966 Pulled By: NickGerleman fbshipit-source-id: e76eac11cde173ef49465d01d793c593017f2ab7
Summary
Fix macro errors for Windows. Current syntax breaks the build of the React Common project on Windows because the ({...}) syntax is not supported; must be replaced with lambda expressions.
Resolves #34090
Changelog
[General] [Fixed] - Fix macro errors for Windows.
@lyahdav @JoshuaGross
Test Plan
Build on react-native-windows repo. Tested in RNW app.