Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate needsCustomLayoutForChildren check to the new architecture #34254

Closed
wants to merge 7 commits into from
Closed

Migrate needsCustomLayoutForChildren check to the new architecture #34254

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
282a170
Tried to implement needsCustomLayoutForChildren
grahammendick Jul 23, 2022
707411c
Passed parent shadow view into update mutation
grahammendick Jul 23, 2022
ff81372
Fixed typo
grahammendick Jul 23, 2022
fb9245d
Changed to view manager wrapper
grahammendick Jul 23, 2022
6060591
Added parent shadow view for animations
grahammendick Jul 25, 2022
bd3cb7c
Added another guess for parent shadow view
grahammendick Jul 25, 2022
01b8619
Checked view manager because roots don't have one
grahammendick Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added another guess for parent shadow view
  • Loading branch information
@grahammendick
grahammendick committed Jul 25, 2022
commit bd3cb7c83c411f6580b7049328834178d1cb6fa5
2 changes: 1 addition & 1 deletion ReactCommon/react/renderer/animations/LayoutAnimationDriver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ void LayoutAnimationDriver::animationMutationsForFrame(

// Create the mutation instruction
mutationsList.emplace_back(ShadowViewMutation::UpdateMutation(
keyframe.viewPrev, mutatedShadowView, {}));
keyframe.viewPrev, mutatedShadowView, keyframe.parentView));

PrintMutationInstruction("Animation Progress:", updateMutation);

Expand Down