Ensure equivalent Flow and TypeScript turbo module definition generates the same output #34251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
kelset
added
p: Microsoft
|
Hi @ZihanChen-MSFT, thanks for the Pr. Could you update the Changelog section, please? If I'm not mistaken, it is taken automatically and it would be nicer to have an informative message for it. Thanks a lot! |
cipolleschi
approved these changes
Jul 25, 2022
|
@cipolleschi I took care of the changelog entry :) |
|
@dmitryrykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@dmitryrykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @ZihanChen-MSFT in 0ce4ea2. When will my fix make it into a release? | Upcoming Releases |
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
…es the same output (facebook#34251) Summary: Flow and TypeScript are two very similar programming languages. They are both recognizable as inputs for turbo module codegen. It is reasonable to require equivalent Flow and TypeScript turbo module definition generates the same output. I add some test cases to ensure this. Glad that no functional inconsistency is found here. ## Changelog [General] [Changed] - codegen: ensure equivalent Flow and TypeScript TM definition generates the same output Pull Request resolved: facebook#34251 Test Plan: `yarn jest` passed in `packages/react-native-codegen` Reviewed By: dmitryrykun Differential Revision: D38116756 Pulled By: cipolleschi fbshipit-source-id: 476adbd171a35813923f2020c826d21b1fc2eeed
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
…es the same output (facebook#34251) Summary: Flow and TypeScript are two very similar programming languages. They are both recognizable as inputs for turbo module codegen. It is reasonable to require equivalent Flow and TypeScript turbo module definition generates the same output. I add some test cases to ensure this. Glad that no functional inconsistency is found here. ## Changelog [General] [Changed] - codegen: ensure equivalent Flow and TypeScript TM definition generates the same output Pull Request resolved: facebook#34251 Test Plan: `yarn jest` passed in `packages/react-native-codegen` Reviewed By: dmitryrykun Differential Revision: D38116756 Pulled By: cipolleschi fbshipit-source-id: 476adbd171a35813923f2020c826d21b1fc2eeed
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 9, 2022
…es the same output (#34620) Summary: Pull request #34251 only partially worked because I didn't notice that there is ` 1` after the snapshot name. In this change I fixed the issue and find out there is one case that Flow and TypeScript parser generate different result. It is expected since the test inputs are different. TypeScript removes one member because there is no `{...X, ...}` type in TypeScript. We could make the codegen support intersection type and rewrite it to `X & {...}`, but this will not be included here anyway. ## Changelog [General] [Changed] - codegen: ensure equivalent Flow and TypeScript TM definition generates the same output Pull Request resolved: #34620 Test Plan: `yarn jest` passed in `packages/react-native-codegen` Reviewed By: NickGerleman Differential Revision: D39321965 Pulled By: cipolleschi fbshipit-source-id: aec60f5c9c18323cbd833bf5705af544d7db2e73
dmytrorykun
pushed a commit
that referenced
this pull request
Sep 14, 2022
…es the same output (#34251) Summary: Flow and TypeScript are two very similar programming languages. They are both recognizable as inputs for turbo module codegen. It is reasonable to require equivalent Flow and TypeScript turbo module definition generates the same output. I add some test cases to ensure this. Glad that no functional inconsistency is found here. ## Changelog [General] [Changed] - codegen: ensure equivalent Flow and TypeScript TM definition generates the same output Pull Request resolved: #34251 Test Plan: `yarn jest` passed in `packages/react-native-codegen` Reviewed By: dmitryrykun Differential Revision: D38116756 Pulled By: cipolleschi fbshipit-source-id: 476adbd171a35813923f2020c826d21b1fc2eeed
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…es the same output (facebook#34620) Summary: Pull request facebook#34251 only partially worked because I didn't notice that there is ` 1` after the snapshot name. In this change I fixed the issue and find out there is one case that Flow and TypeScript parser generate different result. It is expected since the test inputs are different. TypeScript removes one member because there is no `{...X, ...}` type in TypeScript. We could make the codegen support intersection type and rewrite it to `X & {...}`, but this will not be included here anyway. ## Changelog [General] [Changed] - codegen: ensure equivalent Flow and TypeScript TM definition generates the same output Pull Request resolved: facebook#34620 Test Plan: `yarn jest` passed in `packages/react-native-codegen` Reviewed By: NickGerleman Differential Revision: D39321965 Pulled By: cipolleschi fbshipit-source-id: aec60f5c9c18323cbd833bf5705af544d7db2e73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Flow and TypeScript are two very similar programming languages. They are both recognizable as inputs for turbo module codegen. It is reasonable to require equivalent Flow and TypeScript turbo module definition generates the same output.
I add some test cases to ensure this. Glad that no functional inconsistency is found here.
Changelog
[General] [Changed] - codegen: ensure equivalent Flow and TypeScript TM definition generates the same output
Test Plan
yarn jestpassed inpackages/react-native-codegen