Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bake prod env var into react_native_pods.rb for iOS Release build #34234

Closed
wants to merge 4 commits into from
Closed

Bake prod env var into react_native_pods.rb for iOS Release build #34234

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b088b1
Allow `PRODUCTION=1 pod install`
leotm Jul 20, 2022
1fbf34e
Revert "Allow `PRODUCTION=1 pod install`"
leotm Jul 21, 2022
26649db
Bake `PRODUCTION` env var into `react_native_pods.rb`
leotm Jul 21, 2022
17d17f5
Update scripts/react_native_pods.rb
leotm Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions template/ios/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ require_relative '../node_modules/react-native/scripts/native_modules'
platform :ios, '12.4'
install! 'cocoapods', :deterministic_uuids => false

production = ENV["PRODUCTION"] == "1"

target 'HelloWorld' do
config = use_native_modules!

Expand All @@ -12,6 +14,7 @@ target 'HelloWorld' do

use_react_native!(
:path => config[:reactNativePath],
:production => production,
# Hermes is now enabled by default. Disable by setting this flag to false.
# Upcoming versions of React Native may rely on get_default_flags(), but
# we make it explicit here to aid in the React Native upgrade process.
Expand Down