Extract Codegen code from the react_native_pods to its own file #34176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D37755818 |
Base commit: 191eb62 |
Base commit: bf54f1c |
andrestone
reviewed
Jul 14, 2022
scripts/cocoapods/helpers.rb
Outdated
Comment on lines
23
to
27
| def self.find_codegen_file(path) | ||
| return `find #{path} -type f \\( -name "Native*.js" -or -name "*NativeComponent.js" \\)`.split("\n").sort() | ||
| end |
There was a problem hiding this comment.
Hey @cipolleschi! I was wondering maybe adding TypeScript support for for local specs is a change small enough that it could be done here?
There was a problem hiding this comment.
Added. Thanks for the suggestion!
…book#34176) Summary: Pull Request resolved: facebook#34176 It extracts the code related to the codegen from the main `react_native_pods` script to a dedicated file, adding also tests. ## Changelog [iOS][Changed] - Move codegen in separate files Differential Revision: D37755818 fbshipit-source-id: b0dccea0228abef532c63f0f7047bfe17ec170c8
|
This pull request was exported from Phabricator. Differential Revision: D37755818 |
cipolleschi
force-pushed
the
export-D37755818
branch
from
a4c9f85
to
c72b426
Compare
|
This pull request was successfully merged by @cipolleschi in 7d069b2. When will my fix make it into a release? | Upcoming Releases |
kelset
pushed a commit
that referenced
this pull request
Jul 27, 2022
Summary: Pull Request resolved: #34176 It extracts the code related to the codegen from the main `react_native_pods` script to a dedicated file, adding also tests. ## Changelog [iOS][Changed] - Move codegen in separate files Reviewed By: cortinico Differential Revision: D37755818 fbshipit-source-id: 99760d1def26ddbf065fdd234e0d183c2795513c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
It extracts the code related to the codegen from the main
react_native_podsscript to a dedicated file, adding also tests.Changelog
[iOS][Changed] - Move codegen in separate files
Differential Revision: D37755818