Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Hermes setup in a dedicated ruby file #34100

Closed
wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

Summary:
This Diff continue the effort of refactor and test the cocoapods script, moving hermes setup in a dedicated hermes.rb file and adding some tests on the logic of the hermes handling.

Changelog

[iOS][Changed] - move and test Hermes setup from react_native_pods script into a dedicated file

Differential Revision: D37522432

Summary:
This Diff continue the effort of refactor and test the cocoapods script, moving hermes setup in a dedicated `hermes.rb` file and adding some tests on the logic of the hermes handling.

## Changelog
[iOS][Changed] - move and test Hermes setup from react_native_pods script into a dedicated file

Differential Revision: D37522432

fbshipit-source-id: 49493c6d177be70015112aa547e2cbd0bb2ccb5e
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jun 29, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37522432

@react-native-bot react-native-bot added the Platform: iOS iOS applications. label Jun 29, 2022
@analysis-bot
Copy link

analysis-bot commented Jun 29, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,830,116 -232
android hermes armeabi-v7a 7,216,498 -208
android hermes x86 8,139,019 -258
android hermes x86_64 8,120,749 -269
android jsc arm64-v8a 9,695,700 -244
android jsc armeabi-v7a 8,451,163 -196
android jsc x86 9,646,317 -255
android jsc x86_64 10,244,130 -274

Base commit: d6c08bd
Branch: main

@analysis-bot
Copy link

analysis-bot commented Jun 29, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: d6c08bd
Branch: main

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cipolleschi in 468b86b.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner Platform: iOS iOS applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants