Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Hermes the default engine on Android. #34049

Closed
wants to merge 2 commits into from
Closed

Make Hermes the default engine on Android. #34049

wants to merge 2 commits into from

Conversation

cortinico
Copy link
Contributor

Summary:
This just flips the switch for having Hermes on by default
on new projects for React Native.

Changelog:
[Android] [Changed] - Make Hermes the default engine on Android

Differential Revision: D37354079

@cortinico @facebook-github-bot
Do not depend on hermes-engine NPM package anymore
44cf3cc 
Summary:
This removes the `hermes-engine` NPM package from the RN package.json.
Users are not supposed to use this package anymore as we now ship Hermes
bundled with React Native.

More on this here: https://reactnative.dev/architecture/bundled-hermes

Changelog:
[General] [Changed] - Do not depend on hermes-engine NPM package anymore

Differential Revision: D37353977

fbshipit-source-id: 5a3d8cec031fa4521783ec44283936b3bf871c13
@cortinico @facebook-github-bot
Make Hermes the default engine on Android.
0ea5512 
Summary:
This just flips the switch for having Hermes on by default
on new projects for React Native.

Changelog:
[Android] [Changed] - Make Hermes the default engine on Android

Differential Revision: D37354079

fbshipit-source-id: a6c59ca5ac588de51cb50608bc8a8c075c940864
@cortinico cortinico requested a review from hramos as a code owner June 22, 2022 20:02
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner labels Jun 22, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37354079

@pull-bot
Copy link

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 0ea5512

@react-native-bot react-native-bot added the Platform: Android Android applications. label Jun 22, 2022
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,824,322 +0
android hermes armeabi-v7a 7,211,626 +0
android hermes x86 8,134,841 +0
android hermes x86_64 8,115,399 +0
android jsc arm64-v8a 9,690,625 +0
android jsc armeabi-v7a 8,446,834 +0
android jsc x86 9,641,916 +0
android jsc x86_64 10,239,271 +0

Base commit: 97291bf
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 777a92d
Branch: main

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cortinico in a7db8df.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hramos hramos Awaiting requested review from hramos

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner Platform: Android Android applications.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cortinico @facebook-github-bot @pull-bot @analysis-bot @react-native-bot