fix: Make WebSocketTests work in CI #33721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cipolleschi
force-pushed
the
fix/ci-web-socket-tests
branch
2 times, most recently
from
d8fa937
to
bd2cabc
Compare
Base commit: 208422f |
|
I like your Test Plan very much !
|
cipolleschi
force-pushed
the
fix/ci-web-socket-tests
branch
3 times, most recently
from
fadfb71
to
84cf87d
Compare
Base commit: eb2a83b |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
force-pushed
the
fix/ci-web-socket-tests
branch
2 times, most recently
from
d1c5909
to
9eb908f
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
force-pushed
the
fix/ci-web-socket-tests
branch
from
9eb908f
to
dc0b28c
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: This PR reestablish the WebSocketTest in CI which is making the `test_ios_unit` fail. **Note:** the test_ios_unit is actually running integration tests... ## Changelog [iOS] [Changed] - Fix the test_ios_unit test Pull Request resolved: #33721 Test Plan: The CI of this PR is green. 😬 Reviewed By: cortinico Differential Revision: D36002823 Pulled By: cipolleschi fbshipit-source-id: d1b410e409bb5443fce647c06e81dd333105bc92
|
This pull request was exported from Phabricator. Differential Revision: D36002823 |
cipolleschi
force-pushed
the
fix/ci-web-socket-tests
branch
from
dc0b28c
to
f0e3443
Compare
|
This pull request was successfully merged by @cipolleschi in fdbe471. When will my fix make it into a release? | Upcoming Releases |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR reestablish the WebSocketTest in CI which is making the
test_ios_unitfail.Note: the test_ios_unit is actually running integration tests...
Changelog
[iOS] [Changed] - Fix the test_ios_unit test
Test Plan
The CI of this PR is green. 😬