[UIExplorer] PanResponderExample fix for responding to events #3315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
| }); | ||
| }, | ||
|
|
||
| _unHighlight: function() { | ||
| this.circle && this.circle.setNativeProps({ | ||
| backgroundColor: processColor(CIRCLE_COLOR) | ||
| style:{ |
There was a problem hiding this comment.
Ty, I had tried to run the linter (npm run lint) but there were like 100 failures in other files. Is this a legacy method of linting and perhaps a better way to do it? I wasn't sure how to go about the suggested method in CONTRIBUTING.md, as I couldnt find linter.js in the project.
There was a problem hiding this comment.
For reference, after running npm run lint
atticoos
force-pushed
the
bugfix/pan-responder-example
branch
from
a57bace
to
b40027a
Compare
|
Lint feedback addressed via #3315 (diff), amended in ef42abb |
atticoos
force-pushed
the
bugfix/pan-responder-example
branch
from
b40027a
to
ef42abb
Compare
|
Thanks! We should clean up the lint errors too... will open an issue about that. |
|
Cool. I thought perhaps I was running some legacy lint rules 😋 |
|
@facebook-github-bot shipit |
|
☝️ that is sick. |
|
cc @sebmarkbage, your explicit warning is working :) |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1669155743306331/int_phab to review. |
ghost
closed this
in
MattFoley
pushed a commit
to skillz/react-native
that referenced
this pull request
Nov 9, 2015
Summary: Fixes facebook#3312. The example was no longer reacting to touch/drag events. It looks like `setNativeProps` requires the `style` property to contain the style rules. It appears that this warning is [only in development mode](https://github.com/facebook/react-native/blob/381e2acd184fc4ba80a240ba3d7dda0464c6416b/Libraries/ReactIOS/NativeMethodsMixin.js#L115-L117), but after fixing it I am seeing the gestures recognized and properly handled. Running outside of the dev environment yielded the circle to be positioned at the top left of the screen, below the navigation bar, and inaccessible. <img src="https://cloud.githubusercontent.com/assets/656630/10407224/1449b1b2-6eb6-11e5-8116-20d08f7721ec.png" width="350" />  Closes facebook#3315 Reviewed By: @svcscm Differential Revision: D2529010 Pulled By: @vjeux fb-gh-sync-id: 6b79573f42a2520197f77dcb76cd640ea614477f
Crash--
pushed a commit
to Crash--/react-native
that referenced
this pull request
Dec 24, 2015
Summary: Fixes facebook#3312. The example was no longer reacting to touch/drag events. It looks like `setNativeProps` requires the `style` property to contain the style rules. It appears that this warning is [only in development mode](https://github.com/facebook/react-native/blob/381e2acd184fc4ba80a240ba3d7dda0464c6416b/Libraries/ReactIOS/NativeMethodsMixin.js#L115-L117), but after fixing it I am seeing the gestures recognized and properly handled. Running outside of the dev environment yielded the circle to be positioned at the top left of the screen, below the navigation bar, and inaccessible. <img src="https://cloud.githubusercontent.com/assets/656630/10407224/1449b1b2-6eb6-11e5-8116-20d08f7721ec.png" width="350" />  Closes facebook#3315 Reviewed By: @svcscm Differential Revision: D2529010 Pulled By: @vjeux fb-gh-sync-id: 6b79573f42a2520197f77dcb76cd640ea614477f
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3312.
The example was no longer reacting to touch/drag events.
It looks like
setNativePropsrequires thestyleproperty to contain the style rules. It appears that this warning is only in development mode, but after fixing it I am seeing the gestures recognized and properly handled. Running outside of the dev environment yielded the circle to be positioned at the top left of the screen, below the navigation bar, and inaccessible.Error
### After changes