-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to pass ItemSeparatorComponent as React Element #32748
Add ability to pass ItemSeparatorComponent as React Element #32748
Conversation
Base commit: 8cf57a5 |
Base commit: 7b0ba6d |
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Can someone review it ? |
Can you please rebase @retyui. Once the CI is green we can merge this |
ItemSeparatorComponent={<MySeparator/>} // new ability ItemSeparatorComponent={MySeparator} // for old version only this variant
b2e7afb
to
2b734f5
Compare
@cortinico No problem, rebased |
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @retyui in 5854b11. When will my fix make it into a release? | Upcoming Releases |
Summary
Currently
ListHeaderComponent
&ListFooterComponent
allow to use React Componetn & ElemelenBut when you try to pass
ItemSeparatorComponent
as React Element it will throw an errorSo, this PR adds this ability
Changelog
[General] [Changed] - Add ability to pass
ItemSeparatorComponent
as React ElementTest Plan
...