fix(android): Updated TextInput prop types to accomodate for new autoComplete values #32575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-the-new-values]" warning
facebook-github-bot
added
CLA Signed
Base commit: d065b06 |
Base commit: d065b06 |
|
@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
lunaleaps
reviewed
Nov 11, 2021
| @@ -41,56 +41,128 @@ module.exports = { | |||
| 'characters', | |||
| ]): React$PropType$Primitive<'none' | 'sentences' | 'words' | 'characters'>), | |||
| /** | |||
| * Determines which content to suggest on auto complete, e.g.`username`. | |||
| * To disable auto complete, use `off`. | |||
| * Specifies autocomplete hints for the system, so it can provide autofill. On Android, the system will always attempt to offer autofill by using heuristics to identify the type of content. | |||
There was a problem hiding this comment.
Rephrasing @yungsters 's internal comment:
You may want to make a PR for the deprecated prop-types package
|
@lunaleaps merged this pull request in 9eb0881. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the "Failed prop type: Invalid prop
autoCompleteof value[any-of-the-new-values]" warning, as mentioned in #32557.This commit introduced new HintConstants for autofill, but added those only to
TextInput.jsand forgot to add them (and the new docs' description) to eitherAndroidTextInputNativeComponentorDeprecatedTextInputPropTypes.js. I know, the latter has clearly been deprecated, but until it is actually being removed, it shouldn't throw warnings like that.Changelog
[Android] [Fixed] - Updated TextInput prop types to accomodate for new autoComplete values
Test Plan
There is no warning after these changes.