-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use trait collection to resolve border colors #32492
Conversation
PR build artifact for 38d5f6b is ready. |
Base commit: f7a66e6 |
Base commit: 384e1a0 |
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason CLANGFORMAT is flagging those lines:712, 730, 733
I'd say let's rebase this and verify if Circle CI is green. If is still green after the rebase and the internal job I can reformat it manually.
Also cc @sammy-SC for a iOS pass
facebook@c974cbf changed the border colors to be of UIColor instead of CGColor. This allowed working with dark mode to switch the border colors automatically. However, in certain situation the system can't resolve the current trait collection (see https://stackoverflow.com/a/57177411/2525941). This commit resolves the colors with the current trait collection to ensure the right colors are selected. This matches with the behavior of how the background color is resolved (also in displayLayer:).
38d5f6b
to
02ca88d
Compare
Hi @cortinico thanks for the review. I rebased it and amended the lines you mentioned. It looks like there were some whitespaces that the linter didn't agree with. |
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @danilobuerger in 9a35818. When will my fix make it into a release? | Upcoming Releases |
@cortinico Thank you for taking care of my outstanding PRs. I really do appreciate it. |
Sorry those fell through the cracks 👍 Glad we got to merge them though! |
Summary: facebook@c974cbf changed the border colors to be of UIColor instead of CGColor. This allowed working with dark mode to switch the border colors automatically. However, in certain situation the system can't resolve the current trait collection (see https://stackoverflow.com/a/57177411/2525941). This commit resolves the colors with the current trait collection to ensure the right colors are selected. This matches with the behavior of how the background color is resolved (also in displayLayer:). ## Changelog [iOS] [Fixed] - Resolve border platform color based on current trait collection Pull Request resolved: facebook#32492 Test Plan: Same test plan as facebook#29728 Reviewed By: sammy-SC Differential Revision: D33819225 Pulled By: cortinico fbshipit-source-id: 2f8024be7ee7b32d1852373b47fa1437cc569391
Summary
c974cbf changed the border colors to be of UIColor instead of CGColor. This allowed working with dark mode to switch the border colors automatically. However, in certain situation the system can't resolve the current trait collection (see https://stackoverflow.com/a/57177411/2525941). This commit resolves the colors with the current trait collection to ensure the right colors are selected. This matches with the behavior of how the background color is resolved (also in displayLayer:).
Changelog
[iOS] [Fixed] - Resolve border platform color based on current trait collection
Test Plan
Same test plan as #29728