-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only find closest font if system font was not found #32482
Conversation
cc @jacobp100 since this references your commit. |
PR build artifact for 0c5d6e6 is ready. |
0c5d6e6
to
5482c58
Compare
PR build artifact for 5482c58 is ready. |
the failing test seem unrelated to my commit |
Base commit: d6db5c5 |
5482c58
to
4d8cf39
Compare
PR build artifact for 4d8cf39 is ready. |
Hey @danilobuerger, Thanks for the PR. |
Before facebook@f951da9 finding a system font used to return early. In order to allow variants, the referenced patch removed the early return so that variants could be applied later. However, there is no need to find the closest font as we already selected the proper system font. This also fixes a bug with setting a custom font handler via RCTSetDefaultFontHandler whos return could get overwritten by the closest font search.
4d8cf39
to
b7bc552
Compare
Base commit: d6db5c5 |
@cortinico Hi, I rebased it. One test is still failing which seems unrelated to my change. |
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @danilobuerger in 89efa1a. When will my fix make it into a release? | Upcoming Releases |
Summary
Before f951da9 finding a system font used to return early. In order to allow variants, the referenced patch removed the early return so that variants could be applied later. However, there is no need to find the closest font as we already selected the proper system font. This also fixes a bug with setting a custom font handler via RCTSetDefaultFontHandler whos return could get overwritten by the closest font search.
Changelog
[iOS] [Fixed] - Respect RCTSetDefaultFontHandler chosen font
Test Plan