-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Fix crash caused by Image.queryCache parsing null #32101
Conversation
Hi @skychx! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code analysis results:
google-java-format
found some issues. See https://github.com/google/google-java-format
ReactAndroid/src/main/java/com/facebook/react/modules/image/ImageLoaderModule.java
Show resolved
Hide resolved
ReactAndroid/src/main/java/com/facebook/react/modules/image/ImageLoaderModule.java
Show resolved
Hide resolved
Base commit: 4ac42d8 |
Base commit: 4ac42d8 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@ShikaSD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @skychx in ae3d4f7. When will my fix make it into a release? | Upcoming Releases |
…32101) Summary: Pull Request resolved: facebook#32101 Reviewed By: cortinico Differential Revision: D34687038 Pulled By: ShikaSD fbshipit-source-id: 1b39a34a689a043425891416ff141ef622eacd24
No description provided.