Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TouchableNativeFeedback ripple starts on previous touch location #31777

Conversation

intergalacticspacehighway
Copy link
Contributor

@intergalacticspacehighway intergalacticspacehighway commented Jun 26, 2021

Summary

TouchableNativeFeedback's ripple starts from previous location on subsequent presses. This is similar to #31669

Fixes #28944

Issue

Screen.Recording.2021-06-26.at.11.25.32.PM.mov

Fix

Screen.Recording.2021-06-26.at.11.25.53.PM.mov

Changelog

[Android] [Fixed] - TouchableNativeFeedback ripple starts on previous touch location.

Test Plan

Tested TouchableNativeFeedback examples in rn-tester app. Registering coordinates before pressed command fixes the issue.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 26, 2021
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: afafbf8

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,106,188 +1
android hermes armeabi-v7a 8,634,594 -6
android hermes x86 9,545,250 -7
android hermes x86_64 9,511,651 +0
android jsc arm64-v8a 10,752,854 +1
android jsc armeabi-v7a 9,672,531 +7
android jsc x86 10,787,316 +4
android jsc x86_64 11,395,226 -2

Base commit: afafbf8

@facebook-github-bot
Copy link
Contributor

@kacieb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kacieb merged this pull request in d85d72d.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 7, 2021
@intergalacticspacehighway intergalacticspacehighway deleted the touchable-native-feedback-ripple-issue branch August 9, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Needs: React Native Team Attention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TouchableNativeFeedback ripple position bug
4 participants