Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Fix Image does not announce "disabled" #31252

Closed
wants to merge 11 commits into from
Closed

[Accessibility] Fix Image does not announce "disabled" #31252

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
351817d
adding accessible prop to ReactImageManager
fabOnReact Mar 26, 2021
1a14145
AccessibilityExample add image example
fabOnReact Mar 29, 2021
b2988c3
adding basic Java Unit test
fabOnReact Mar 29, 2021
cf665dc
rename Test case
fabOnReact Mar 29, 2021
326e338
Merge branch 'master' into fix/image-accessibility
fabOnReact Apr 6, 2021
5b06ede
Merge branch 'master' into fix/image-accessibility
fabOnReact Apr 27, 2021
3e9fc4e
update test example title
fabOnReact May 2, 2021
5c16b18
use local instead of network asset
fabOnReact May 2, 2021
43ba382
remove example from rn-tester ImageExample
fabOnReact May 2, 2021
3485fa0
rename example accessibilityLabel
fabOnReact May 2, 2021
f5e4a16
moving style changes from image to disabledImage
fabOnReact May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename Test case
  • Loading branch information
@fabOnReact
fabOnReact committed Mar 29, 2021
commit cf665dc6c2360e5d88a991bc27a88da3d8902cc5
2 changes: 1 addition & 1 deletion ReactAndroid/src/test/java/com/facebook/react/views/image/ReactImagePropertyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ public void testRoundedCorners() {
}

@Test
public void testRoundedCorners() {
public void testAccessibilityFocus() {
ReactImageManager viewManager = new ReactImageManager();
ReactImageView view = viewManager.createViewInstance(mThemeContext);
viewManager.setAccessible(view, true);
Expand Down