Skip to content

Conversation

acoates-ms
Copy link
Contributor

@acoates-ms acoates-ms commented Jan 15, 2021

Summary

The windows CI tests are flaky due to network failures trying to install the android SDK. This modifies the CI to retry a couple of times if the first install fails.

CircleCI will timeout the command if there is no output to the console for 10mins. I've added a timeout to the choco command for 9mins, which should cause it to timeout before the circleci one (assuming that it spends a non-zero time with output before hanging on the download) On successful downloads runs the download seems to be substantially quicker than the 10min timeout.

I added --force and --forcedependencies on the retries, otherwise if the jdk package fails, but the androidsdk package installs, the retry will still not install the jdk package.

This doesn't fully fix the issue, since the CI is still hitting the network, which could be flaky all 3 attempts. But hopefully it'll improve the success rate somewhat. -- Really the Windows CI job should have some kind of docker image or something that already has all the prereqs installed.

Changelog

[Internal] [Fixed] - Windows CI Android SDK install retry

Test Plan

We'll see if the windows CI becomes more reliable

@acoates-ms acoates-ms requested a review from hramos as a code owner January 15, 2021 00:04
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner labels Jan 15, 2021
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 280f524

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,896,656 -18,306
android hermes armeabi-v7a 8,394,390 -18,217
android hermes x86 9,384,950 -18,211
android hermes x86_64 9,330,092 -18,599
android jsc arm64-v8a 10,348,457 -18,297
android jsc armeabi-v7a 9,829,278 -18,222
android jsc x86 10,398,251 -18,211
android jsc x86_64 10,983,646 -18,607

Base commit: 280f524

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@hramos merged this pull request in f66dcab.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 3, 2021
@acoates-ms acoates-ms deleted the ciwindowsretry branch September 2, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants