Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch Readme version badge source to shields.io #30411

Closed
wants to merge 1 commit into from

Conversation

Simek
Copy link
Collaborator

@Simek Simek commented Nov 17, 2020

Summary

Lately there are some loading issues for the fury.io badges service which results in missing image and alt text visible in the Readme.

This PR fixes that issue by switching to shields.io version badge - badge service that has been used for few other badges already.

Changelog

[Internal] [Changed] - change Readme npm version badge to shields.io

Test Plan

All badges will appear in the Readme file. 🙂

@Simek Simek requested review from cpojer and hramos as code owners November 17, 2020 15:51
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 17, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 2669118

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,525,501 +0
android hermes armeabi-v7a 7,110,737 +0
android hermes x86 7,965,962 +0
android hermes x86_64 7,877,257 +0
android jsc arm64-v8a 8,989,758 +0
android jsc armeabi-v7a 8,558,104 +0
android jsc x86 8,991,720 +0
android jsc x86_64 9,543,270 +0

Base commit: 2669118

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Simek in 8cc4467.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants