Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressability: fix typo in variable, follow event check pattern, small tweak #30151

Closed

Conversation

Simek
Copy link
Collaborator

@Simek Simek commented Oct 9, 2020

Summary

This small PR introduces the following changes to the Pressability:

  • fixes typo in internal isActivationTransiton variable name
  • assigns onPressMove to variable before check and potential usage (this is the common pattern in this file)
  • utilizes destructuring assignment to simplify passing coordinates to _touchActivatePosition

Changelog

[Internal] [Fixed] - Pressability: fix typo in variable, follow event check pattern, small tweak

Test Plan

Successful yarn test run.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 9, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,385,801 0
android hermes armeabi-v7a 7,013,117 0
android hermes x86 7,828,013 0
android hermes x86_64 7,717,499 0
android jsc arm64-v8a 9,532,102 0
android jsc armeabi-v7a 9,151,226 0
android jsc x86 9,396,778 0
android jsc x86_64 9,978,488 0

Base commit: 3aa4de7

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 3aa4de7

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nadiia has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link

@nadiia nadiia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Simek This looks good. Thank you for the fix!

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Simek in 7485208.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants