Make sure js bundle still exists at bundle-output path #30149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
cc @alloy |
Base commit: 0d02c60 |
Base commit: 0d02c60 |
There was a problem hiding this comment.
@appden has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @janicduplessis in 3a41f69. When will my fix make it into a release? | Upcoming Releases |
lmarques6
pushed a commit
to TeamGuilded/react-native
that referenced
this pull request
Oct 27, 2020
Summary: Since changes to support hermes on iOS the js bundled is moved away from the location where it is generated when calling metro. This causes issues with the RN sentry integration since it relies on intercepting this path to find the bundle file after running react-native-xcode.sh. Seems kind of like a hacky way to get the bundle location, but let's avoid breaking it. https://github.com/getsentry/sentry-cli/blob/master/src/commands/react_native_xcode.rs ## Changelog [iOS] [Fixed] - Make sure js bundle still exists at bundle-output path Pull Request resolved: facebook#30149 Test Plan: Checked that the bundle file exists both at bundle-output path and in the .app. Checked that the sentry release script works. Reviewed By: cpojer Differential Revision: D24480115 Pulled By: appden fbshipit-source-id: c01c80d47ed54319f97063ec635c021552a95c22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since changes to support hermes on iOS the js bundled is moved away from the location where it is generated when calling metro. This causes issues with the RN sentry integration since it relies on intercepting this path to find the bundle file after running react-native-xcode.sh. Seems kind of like a hacky way to get the bundle location, but let's avoid breaking it.
https://github.com/getsentry/sentry-cli/blob/master/src/commands/react_native_xcode.rs
Changelog
[iOS] [Fixed] - Make sure js bundle still exists at bundle-output path
Test Plan
Checked that the bundle file exists both at bundle-output path and in the .app.
Checked that the sentry release script works.