Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused accessibility props from TextInput #30083

Conversation

jeswinsimon
Copy link
Contributor

Summary

TextInput component does not support accessibility props. The underlying Native components for both iOS and Android does not support accessibility props. The unused props have been removed from the component.

#29981

Changelog

[General] [Removed] - Removed unused, undocumented accessibility props from TextInput

Test Plan

The TextInput component should work without any change in both iOS and Android

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 1, 2020
@analysis-bot
Copy link

analysis-bot commented Oct 1, 2020

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,385,801 0
android hermes armeabi-v7a 7,009,021 -4,096
android hermes x86 7,823,917 0
android hermes x86_64 7,717,499 0
android jsc arm64-v8a 9,528,006 0
android jsc armeabi-v7a 9,147,130 0
android jsc x86 9,392,682 0
android jsc x86_64 9,974,392 0

Base commit: edbe154

@analysis-bot
Copy link

analysis-bot commented Oct 1, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: edbe154

@kelset kelset added the Needs: Docs Website PR To encourage the authors to create a website PR for documentation. label Oct 12, 2020
@github-actions
Copy link

github-actions bot commented Aug 6, 2023

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Aug 6, 2023
@github-actions
Copy link

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Needs: Docs Website PR To encourage the authors to create a website PR for documentation. Stale There has been a lack of activity on this issue and it may be closed soon. Type: Removal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants