Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple of missing display names in integration test components #29902

Closed

Conversation

NickGerleman
Copy link
Contributor

Summary

IntegtationTestsApp looks for a display name of each component to register it in the AppRegistry, along with show its name in the tests lists. Add the missing display names back to these tests.

Changelog

[iOS] [Fixed] - Fix a couple of missing display names in integration test components

Test Plan

All integration tests now show up in the list.

IntegtationTestsApp looks for a display name to register the test component, along with show its name in the tests lists. Add the missing display names back to these tests.
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner labels Sep 9, 2020
@react-native-bot react-native-bot added Bug Platform: iOS iOS applications. labels Sep 9, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,208,869 -552
android hermes armeabi-v7a 6,858,053 -540
android hermes x86 7,643,509 -560
android hermes x86_64 7,534,461 -548
android jsc arm64-v8a 9,367,594 -1,464
android jsc armeabi-v7a 9,008,890 -1,472
android jsc x86 9,230,310 -1,472
android jsc x86_64 9,807,458 -1,460

Base commit: 7e89934

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 7e89934

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@appden has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@appden merged this pull request in c66aa8a.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner Platform: iOS iOS applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants