-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump SoLoader to 0.9.0 #29821
bump SoLoader to 0.9.0 #29821
Conversation
Base commit: 93e7a7a |
@mdvacca please review and merge |
Base commit: 93e7a7a |
I think we target SDK 19 now, so that's Android 4.4 right? Do we still need this urgently?
Any particular reason to upgrade Fresco? (I'm trying to understand the motivation for each upgrade for each of the dependencies we have) |
I think it's important to track FB dependencies because FB will use them internally from master, thus reduce parity between OSS and FB. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request was successfully merged by @dulmandakh in 7465239. When will my fix make it into a release? | Upcoming Releases |
Summary: SoLoader fixed crash on Android 4.1, and includes many improvements and fixes https://github.com/facebook/SoLoader/releases/tag/v0.9.0. Also Fresco 2.3.0 depends on it, and will create a PR soon to bump Fresco. ## Changelog [Android] [Changed] - Bump SoLoader to 0.9.0 Pull Request resolved: #29821 Test Plan: CI is green Reviewed By: fkgozali Differential Revision: D23477538 Pulled By: mdvacca fbshipit-source-id: d2d982d5c5c84fc173dc66dfe069713ca90711a8
Summary: SoLoader fixed crash on Android 4.1, and includes many improvements and fixes https://github.com/facebook/SoLoader/releases/tag/v0.9.0. Also Fresco 2.3.0 depends on it, and will create a PR soon to bump Fresco. ## Changelog [Android] [Changed] - Bump SoLoader to 0.9.0 Pull Request resolved: facebook#29821 Test Plan: CI is green Reviewed By: fkgozali Differential Revision: D23477538 Pulled By: mdvacca fbshipit-source-id: d2d982d5c5c84fc173dc66dfe069713ca90711a8
Summary
SoLoader fixed crash on Android 4.1, and includes many improvements and fixes https://github.com/facebook/SoLoader/releases/tag/v0.9.0. Also Fresco 2.3.0 depends on it, and will create a PR soon to bump Fresco.
Changelog
[Android] [Changed] - Bump SoLoader to 0.9.0
Test Plan
CI is green