Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove accessibilityStates validAttributes config from ReactNativeViewViewConfig.js #29656

Conversation

luism3861
Copy link
Contributor

@luism3861 luism3861 commented Aug 14, 2020

Summary

this little PR remove accesibilityStates config in validAttributes, like comment says it can be removed after next release.

Changelog

Javascript

Test Plan

@pull-bot
Copy link

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 8191023

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,003,081 51
android hermes armeabi-v7a 6,666,662 19
android hermes x86 7,423,391 36
android hermes x86_64 7,314,282 35
android jsc arm64-v8a 9,162,793 -5
android jsc armeabi-v7a 8,818,518 -10
android jsc x86 9,011,190 0
android jsc x86_64 9,588,279 -4

Base commit: dc7defa

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 14, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: dc7defa

@Naturalclar
Copy link
Contributor

reference for more information on why it can be removed: #26168

@luism3861
Copy link
Contributor Author

@yungsters could you review this PR?

@facebook-github-bot
Copy link
Contributor

@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@philIip philIip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 18, 2021
@facebook-github-bot
Copy link
Contributor

@yungsters merged this pull request in 1121ed9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants