Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ScrollView.maintainVisibleContentPosition on Android #29466

Closed
wants to merge 28 commits into from
Closed

Support for ScrollView.maintainVisibleContentPosition on Android #29466

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
b1df249
:construction: maintainVisibleContentPosition on Android
maxoumime Jul 16, 2020
8c29447
:construction: maintainVisibleContentPosition on Android
maxoumime Jul 17, 2020
a2509b3
:sparkles: maintainVisibleContentPosition on Android
maxoumime Jul 21, 2020
8d4fd42
:wrench: Add sample
maxoumime Jul 21, 2020
99b69db
:wrench: Cleanup and comments
maxoumime Jul 21, 2020
63cb074
:wrench: maintainVisibleContentPosition for Android - horizontal
maxoumime Jul 22, 2020
2f3110b
:wrench: Self-review
maxoumime Jul 22, 2020
344b9db
Merge remote-tracking branch 'facebook/master'
maxoumime Jul 22, 2020
84ecefc
:wrench: Lint
maxoumime Jul 22, 2020
9d5eef8
:wrench: Lint
maxoumime Jul 22, 2020
45c5ecf
:wrench: Method references not available
maxoumime Jul 22, 2020
3992154
:wrench: Fix CI
maxoumime Jul 22, 2020
19603e1
:wrench: Fix CI #2
maxoumime Jul 22, 2020
174f348
:wrench: Fix CI
maxoumime Jul 27, 2020
2e37d50
Merge branch 'master' of https://github.com/facebook/react-native
maxoumime Aug 12, 2020
04b8905
Merge remote-tracking branch 'facebook/master' into master
maxoumime Sep 8, 2020
7a67669
Merge branch 'master' into master
maxoumime Sep 9, 2020
1bc4b8d
Merge branch 'master' into master
maxoumime Sep 10, 2020
4039ecd
Merge branch 'master' into master
maxoumime Feb 5, 2021
9bed499
:tshirt:
maxoumime Feb 5, 2021
421f329
Merge remote-tracking branch 'facebook/master'
maxoumime Jun 8, 2021
7761851
:wrench: reactScrollTo doesn't exist anymore
maxoumime Jun 8, 2021
cc6bdf0
:tshirt:
maxoumime Jun 8, 2021
3257a58
Merge branch 'master' of https://github.com/facebook/react-native
maxoumime Jul 2, 2021
fca378d
:wrench: :robot:
maxoumime Jul 2, 2021
03f7d9d
Merge branch 'master' into master
maxoumime Jul 16, 2021
0a15381
:see_no_evil:
maxoumime Jul 16, 2021
51beb41
Merge remote-tracking branch 'facebook/main'
maxoumime Aug 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
🔧 Lint
  • Loading branch information
@maxoumime
maxoumime committed Jul 22, 2020
commit 9d5eef812626f85b76e05e1ca1e52915e0985b41
2 changes: 1 addition & 1 deletion Libraries/Components/ScrollView/ScrollViewStickyHeader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ class ScrollViewStickyHeader extends React.Component<Props, State> {
// Fabric Detection
// eslint-disable-next-line dot-notation
const isFabric = !!(
this._ref && this._ref._internalInstanceHandle?.stateNode?.canonical
this._ref && this._ref['_internalInstanceHandle']?.stateNode?.canonical
);

// Initially and in the case of updated props or layout, we
Expand Down