Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isModalInPresentation prop for iOS >= 13 #29249

Closed
wants to merge 7 commits into from
Closed

Conversation

luco
Copy link

@luco luco commented Jun 29, 2020

Summary

Adds a isModalInPresentation for iOS >= 13, which prevents the modal with presentationStyle set as pageSheet or formSheet being dismissed with swipe down.

Changelog

[iOS] [Added] - isModalInPresentation Modal prop for iOS >= 13 for preventing modal with presentationStyle set as pageSheet or formSheet being dismissed with swipe down.

Test Plan

ezgif-4-4e84d1284557

@luco luco requested a review from shergin as a code owner June 29, 2020 18:29
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 29, 2020
@react-native-bot react-native-bot added Platform: iOS iOS applications. Type: Enhancement A new feature or enhancement of an existing feature. labels Jun 29, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: a50f736

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,765,142 3,213
android hermes armeabi-v7a 6,428,360 3,190
android hermes x86 7,152,292 3,196
android hermes x86_64 7,042,259 3,196
android jsc arm64-v8a 8,938,503 3,608
android jsc armeabi-v7a 8,594,115 3,629
android jsc x86 8,768,762 3,595
android jsc x86_64 9,344,373 3,627

Base commit: a50f736

@mrousavy
Copy link
Contributor

mrousavy commented Jul 9, 2020

EDIT: Nevermind I still had the non-patched version in cache.

On react-native 0.63 this doesn't work anymore, the modalInPresentation propertiy must somehow get overridden?

@luco
Copy link
Author

luco commented Jul 15, 2020

@shergin Can you review this?

@rafaelmotta
Copy link

Is there any way of reviewing this pull request? It's super annoying this issue, and there's no way to use a modal with pageSheet or formSheet with this bug.

@github-actions
Copy link

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Aug 14, 2023
@github-actions
Copy link

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Platform: iOS iOS applications. Stale There has been a lack of activity on this issue and it may be closed soon. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants