-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isModalInPresentation prop for iOS >= 13 #29249
Conversation
Base commit: a50f736 |
Base commit: a50f736 |
EDIT: Nevermind I still had the non-patched version in cache.
|
@shergin Can you review this? |
Is there any way of reviewing this pull request? It's super annoying this issue, and there's no way to use a modal with pageSheet or formSheet with this bug. |
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This PR was closed because it has been stalled for 7 days with no activity. |
Summary
Adds a
isModalInPresentation
for iOS >= 13, which prevents the modal withpresentationStyle
set aspageSheet
orformSheet
being dismissed with swipe down.Changelog
[iOS] [Added] -
isModalInPresentation
Modal prop for iOS >= 13 for preventing modal withpresentationStyle
set aspageSheet
orformSheet
being dismissed with swipe down.Test Plan