[Android ]Fix debugging on android for 0.63

[devon94]

Summary

Currently on react native 0.63-rc.0 and 0.63-rc.1 enabling debugging throws an exception. It looks like something may have been missed in unregistering JSDevSupport in this commit c20963e

This should fix #28746 and #29136

Changelog

[Android] [Fixed] - Fix crash when enabling debug

Test Plan

To recreate the bug:

npx react-native init RN063 --version 0.63.0-rc.1
react-native start
react-native run-android
Enable debug mode from react native dev menu

After this commit, the crash no longer occurs

[facebook-github-bot]

Hi @devon94!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 3005464

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[kesha-antonov]

Yes, please!

[RSNara]

Whoops. Thanks for the fix! 😅

[facebook-github-bot]

@RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @devon94 in 8c42c01.

^{When will my fix make it into a release? | Upcoming Releases}

[BrunoVillanova]

Thank you very much for this fix!!
You are the man!

[TheWirv]

I've had this problem since upgrading to 0.63.rc1, but this commit/merge doesn't fix it.
Below is a screenshot that I just took, after building the app completely from scratch, after having fixed my RN files with this commit and creating a patch file as well:
I can give more input as needed.

Edit: Also, isn't the error message in the IllegalArgumentException wrong because it was copy-pasted?
Here I think it should be "In DebugCorePackage, ...

Here's the screenshot

[devon94]

@TheWirv Did you need to build the android source? If you choose to modify the code in node modules of or if you use RN source code without building from source, it won't apply native android changes. You can look at https://github.com/facebook/react-native/wiki/Building-from-source for reference and also this branch where I built the source code to test https://github.com/devon94/react-native/tree/fix-android-debug-release. Or you can also wait until a new RN release.

[TheWirv]

@TheWirv Did you need to build the android source? If you choose to modify the code in node modules of or if you use RN source code without building from source, it won't apply native android changes. You can look at https://github.com/facebook/react-native/wiki/Building-from-source for reference and also this branch where I built the source code to test https://github.com/devon94/react-native/tree/fix-android-debug-release. Or you can also wait until a new RN release.

@devon94 Thanks for the clarification. No, I don't need to build from source. I honestly didn't that this is necessary for Android source. I thought, I could just use patch-package to patch it, like I would with any other package. Then, I guess, I'll have to wait until the next RC/full release.

[BrunoVillanova]

It is working now on v0.63.0 final, thanks to @devon94 !