Fix issue with Swift version compatibility

[augustl]

Summary

Our app did not build when we added a dependency to our podspec that was built with swift 5.1.

After a lot of back and forth, we found the flag LIBRARY_SEARCH_PATHS , and also found that simply clearing it out completely made the app build just fine, and did not cause any other issues with the building or running of our app.

With the flag in place, we got weird errors such as:

Undefined symbols for architecture x86_64:
  "type metadata accessor for (extension in Foundation):__C.NSURLSession.DataTaskPublisher", referenced from:
      (extension in TinyNetworkingObjcIO):__C.NSURLSession.load<A>(TinyNetworkingObjcIO.Endpoint<A>) -> Combine.AnyPublisher<A, Swift.Error> in libTinyNetworkingObjcIO.a(Endpoint.o)
      lazy protocol witness table accessor for type (extension in Foundation):__C.NSURLSession.DataTaskPublisher and conformance (extension in Foundation):__C.NSURLSession.DataTaskPublisher : Combine.Publisher in Foundation in libTinyNetworkingObjcIO.a(Endpoint.o)
  "protocol conformance descriptor for (extension in Foundation):__C.NSURLSession.DataTaskPublisher : Combine.Publisher in Foundation", referenced from:
      lazy protocol witness table accessor for type (extension in Foundation):__C.NSURLSession.DataTaskPublisher and conformance (extension in Foundation):__C.NSURLSession.DataTaskPublisher : Combine.Publisher in Foundation in libTinyNetworkingObjcIO.a(Endpoint.o)
  "(extension in Foundation):__C.NSURLSession.dataTaskPublisher(for: Foundation.URLRequest) -> (extension in Foundation):__C.NSURLSession.DataTaskPublisher", referenced from:
      (extension in TinyNetworkingObjcIO):__C.NSURLSession.load<A>(TinyNetworkingObjcIO.Endpoint<A>) -> Combine.AnyPublisher<A, Swift.Error> in libTinyNetworkingObjcIO.a(Endpoint.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

It seems that there are some binary incompatibilities in how Swift 5.1 and newer generates symbols. What used to be NSURLSession.DataTaskPublisher is now URLSession.DataTaskPublisher. We think..

See also: https://stackoverflow.com/questions/62467663/how-to-fix-ios-xcode-build-error-undefined-symbol-c-nsurlsession-datataskpub/62467664#62467664

Changelog

[iOS] [Fixed] - Removed unneedded LIBRARY_SEARCH_PATHS from xcodebuild config

Test Plan

This is not a very testable change. There's an obvious risk of this flag being needed by some projects, even though it worked fine in our project.

So I'm not really able to provide a detailed test plan, unfortunately.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	6,765,257	0
android	hermes	armeabi-v7a	6,428,498	0
android	hermes	x86	7,152,413	0
android	hermes	x86_64	7,042,381	0
android	jsc	arm64-v8a	8,938,537	0
android	jsc	armeabi-v7a	8,594,144	0
android	jsc	x86	8,768,809	0
android	jsc	x86_64	9,344,409	0

Base commit: ff69028

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: ff69028

[augustl]

I have no idea why this caused the build to fail with Entry file RNTester/js/RNTesterApp.ios.js does not exist. If you use another file as your entry point, pass ENTRY_FILE=myindex.js' :D Maybe the build error is a random act of failed build? Or maybe I actually broke it, who knows :)

[github-actions]

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This PR was closed because it has been stalled for 7 days with no activity.