Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] onKeyPress event not fired with numeric keys #29046

Closed
wants to merge 7 commits into from
Closed

[Android] onKeyPress event not fired with numeric keys #29046

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bd52916
log keypress events from numeric keys
fabOnReact Jun 3, 2020
76546b3
code review from https://github.com/nukemonk
fabOnReact Dec 5, 2020
df7d841
Merge branch 'master' into numpad-keypress-not-logging
fabOnReact Dec 20, 2020
a9f8616
analysis-bot - google-java-format issue
fabOnReact Dec 21, 2020
564762a
Merge branch 'master' into numpad-keypress-not-logging
fabOnReact Jan 5, 2021
2d26997
Merge branch 'master' into numpad-keypress-not-logging
fabOnReact Jan 25, 2021
169cc54
Merge branch 'master' into numpad-keypress-not-logging
fabOnReact Feb 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...src/main/java/com/facebook/react/views/textinput/ReactEditTextInputConnectionWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,13 @@ public boolean deleteSurroundingText(int beforeLength, int afterLength) {
@Override
public boolean sendKeyEvent(KeyEvent event) {
if (event.getAction() == KeyEvent.ACTION_DOWN) {
boolean isNumberKey = event.getUnicodeChar() < 58 && event.getUnicodeChar() > 47;
if (event.getKeyCode() == KeyEvent.KEYCODE_DEL) {
dispatchKeyEvent(BACKSPACE_KEY_VALUE);
} else if (event.getKeyCode() == KeyEvent.KEYCODE_ENTER) {
dispatchKeyEvent(ENTER_KEY_VALUE);
} else if (isNumberKey) {
dispatchKeyEvent(String.valueOf(event.getNumber()));
}
}
return super.sendKeyEvent(event);
Expand Down